mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jieyu <...@git.apache.org>
Subject [GitHub] mesos pull request #263: Allow nested containers in pods to have separate na...
Date Fri, 16 Feb 2018 01:21:28 GMT
Github user jieyu commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/263#discussion_r168652041
  
    --- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
    @@ -721,7 +721,7 @@ Future<Option<ContainerLaunchInfo>> NetworkCniIsolatorProcess::prepare(
         env->set_name("LIBPROCESS_IP");
         env->set_value("0.0.0.0");
     
    -    if (!containerId.has_parent()) {
    +    if (needsSeparateNs) {
    --- End diff --
    
    This should be
    ```
    if (!isDebugContainer && (!nestedContainer || !joinParentNetwork))
    ```


---

Mime
View raw message