From dev-return-49901-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Fri Jan 5 21:04:35 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 480C2180647 for ; Fri, 5 Jan 2018 21:04:35 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 37E38160C27; Fri, 5 Jan 2018 20:04:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7D3D7160C15 for ; Fri, 5 Jan 2018 21:04:34 +0100 (CET) Received: (qmail 35826 invoked by uid 500); 5 Jan 2018 20:04:33 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 35740 invoked by uid 99); 5 Jan 2018 20:04:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jan 2018 20:04:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 687E0C349C for ; Fri, 5 Jan 2018 20:04:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.898 X-Spam-Level: * X-Spam-Status: No, score=1.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=uber.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 64sqLjyBhhOq for ; Fri, 5 Jan 2018 20:04:30 +0000 (UTC) Received: from mail-io0-f180.google.com (mail-io0-f180.google.com [209.85.223.180]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8EEF75FB04 for ; Fri, 5 Jan 2018 20:04:30 +0000 (UTC) Received: by mail-io0-f180.google.com with SMTP id t63so6928986iod.0 for ; Fri, 05 Jan 2018 12:04:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uber.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=7JO8zZWvp+4VxPcvAZ6/ymiR6zoOUPH8U8u6nFm6nn0=; b=W/mnvZ9K7WRSod4Yg9Y4Kgi4wKItiKYl4GAtEZBx2iggjE5N+mtyHulx/mKsx6ju42 +U4Qj/u9wqEXJXJ1ZtT+QhHQvZ+umyoHwfre/Ftl1h+7BntX7LKguphar9+k0PpmmULP y8yMZDLgRqagCxLGpHgIM14/IWDyWh8NrolH0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=7JO8zZWvp+4VxPcvAZ6/ymiR6zoOUPH8U8u6nFm6nn0=; b=ZxzkQPDmFFTLwnejVA2ZWsepiS5w00T5+wfyAh0m/uXGoB3DZ1q8kTF7WHX4/pcW3D hITLbM0EaEE3rYH4fPbfaC3MY8P2L+vvofamXVkeALmx8OAt3xagUIaexkAcd0qfaBGX aSiFpzwTFoq3SudkEvBqQ7jjaZohbl93aqeJtfuz5DdS4t2EEtS4LK/AgMYWvUxs3DTy Y3vgQIQhxG9BYtt7OeH/WTQOD0Qsp01f2pA1U9b54mWsOIron8m4FSkYWGCHBUC4maj/ S5R34eVosld5XhuUHX5FX+8rAdAx6QGp5yI8t9NqYy3zKD1nu30Qd4dhRA4N+BLDrZJ9 mIoQ== X-Gm-Message-State: AKwxytczUBMBmtL6uzV068Kxt8QZGhFFH4hHWumm1InkKPdMGAit0Kfh y5YsRXOhpYO6WDsIkrVJRhCZ2O28luizJ6mquNXm1A== X-Google-Smtp-Source: ACJfBou8q7KSBBFAF35F4ZzPzYJ1DozNyJJ75LzTUVg8D1TVUU6a5GO1iqGH0uGRP2+tthZKQiWjhp1uT9FyB9FAfBk= X-Received: by 10.107.29.16 with SMTP id d16mr4676700iod.165.1515182669552; Fri, 05 Jan 2018 12:04:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.36.67.199 with HTTP; Fri, 5 Jan 2018 12:04:09 -0800 (PST) From: Eric Chung Date: Fri, 5 Jan 2018 12:04:09 -0800 Message-ID: Subject: Replacing ad hoc virtualenvs for testing and linting with tox To: dev@mesos.apache.org Content-Type: multipart/alternative; boundary="001a113feeccca493205620cf4ae" --001a113feeccca493205620cf4ae Content-Type: text/plain; charset="UTF-8" Hello mesos devs, I'd like to propose that we replace some of our bash scripts for building ad hoc virtualenvs with tox , a tool for automating lifecycle management of virtualenvs using declarative configuration files. Specifically, virtualenvs created for the purpose of linting (support/.virtaulenv) and unit testing (in src/python) can be managed by tox, which provide the following benefits: 1. Eliminate the need for maintaining shell scripts for managing virtualenvs 2. We will no longer need to install *ALL* dependencies into the same virtualenv for the purpose of linting -- we can have distributed tox.ini files in wherever python linting is required, and just run tox there. 3. Easily run tests for multiple environments, e.g. python3 vs python2. This will make migration to python3 much easier, which we are facing increasing pressure to address. The biggest concern here would probably the change in dependencies, since it may seem like we're adding an additional dependency to mesos. However since virtualenv is a dependency of tox, we will not break any existing dependencies, as requiring tox will automatically require virtualenv. Otherwise I don't really see any downside in making the switch. Please let me know what you think! Eric --001a113feeccca493205620cf4ae--