mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent <...@git.apache.org>
Subject [GitHub] mesos pull request #221: Fixed a bug in the logging of cni isolator.
Date Tue, 20 Jun 2017 06:45:52 GMT
Github user haosdent commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/221#discussion_r122892058
  
    --- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
    @@ -1994,11 +1995,13 @@ int NetworkCniIsolatorSetup::execute()
           return EXIT_FAILURE;
         }
     
    -    if (os::spawn("ifconfig", {"ifconfig", "lo", "up"}) != 0) {
    -      cerr << "Failed to bring up the loopback interface in the new "
    -           << "network namespace of pid " << flags.pid.get()
    -           << ": " << os::strerror(errno) << endl;
    -      return EXIT_FAILURE;
    +    int spawn = os::spawn("ifconfig", {"ifconfig", "lo", "up"});
    +
    +    if (spawn != 0) {
    +        cerr << "Failed to bring up the loopback interface in the new "
    +             << "network namespace of pid " << flags.pid.get()
    +             << ": " << (spawn < 0 ? "failed to fork process" : WSTRINGIFY(spawn))
<< endl;
    --- End diff --
    
    Replace `failed` to `Failed`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message