mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Inconsistent naming of support scripts
Date Sat, 14 Jan 2017 01:25:53 GMT
commit 8b8f4af3c4d70c3ffcb70092da0fb0cd636bbe9a
Author: Michael Park <mpark@apache.org>
Date:   Wed Jan 11 14:54:23 2017 -0800

    Renamed executable files from '_' to '-' in the `support` directory.

    Review: https://reviews.apache.org/r/55487

On Fri, Sep 2, 2016 at 1:45 AM, Vinod Kone <vinodkone@gmail.com> wrote:

> Nope. Didn't get around to doing it. Feel free to take over.
>
> @vinodkone
>
> > On Sep 2, 2016, at 8:56 AM, Michael Park <mpark@apache.org> wrote:
> >
> > Vinod, are there patches out for these? I would like to help close this
> off.
> >
> >> On Tue, Feb 16, 2016 at 6:30 PM, Vinod Kone <vinodkone@apache.org>
> wrote:
> >>
> >> Thanks for the feedback. I'll send out a patch.
> >>
> >> On Tue, Feb 16, 2016 at 9:12 AM, haosdent <haosdent@gmail.com> wrote:
> >>
> >>>> running `find /usr/local/bin -name "*-*" | wc -l` returned 142 while
> >> `find
> >>> /usr/local/bin -name "*_*" | wc -l` was only 17. So I feel using hyphen
> >> for
> >>> executables is more standard.
> >>>
> >>> +1 Same for me.
> >>>
> >>> On Wed, Feb 17, 2016 at 1:10 AM, Alexander Rojas <
> >> alexander@mesosphere.io>
> >>> wrote:
> >>>
> >>>> +1 for consistency, +1 for executables.
> >>>>
> >>>> I do enough finger yoga while using emacs!
> >>>>
> >>>> running `find /usr/local/bin -name "*-*" | wc -l` returned 142 while
> >>> `find
> >>>> /usr/local/bin -name "*_*" | wc -l` was only 17. So I feel using
> hyphen
> >>> for
> >>>> executables is more standard.
> >>>>
> >>>>> On 11 Feb 2016, at 14:58, Michael Park <mpark@apache.org>
wrote:
> >>>>>
> >>>>> +1 for consistency, +1 for hyphens for executables.
> >>>>>
> >>>>>> On 11 February 2016 at 14:25, Kevin Klues <klueska@gmail.com>
> wrote:
> >>>>>>
> >>>>>> I typically think of files having dashes as binaries or scripts
that
> >>>>>> are runnable, whereas files with underscores are meant as source
or
> >>>>>> otherwise supplementary to the binary produced (e.g. a supplementary
> >>>>>> python library that the main python program imports).  I'm 
not sure
> >>>>>> where I inherited this convention from, but it's always been
the way
> >>>>>> I've done things.
> >>>>>>
> >>>>>> As far as our code base goes, we seem to use this convention
as well
> >>>>>> with our mesos-master.sh. mesos-slave.sh, etc. binaries.
> >>>>>>
> >>>>>> On Thu, Feb 11, 2016 at 2:17 PM, Vinod Kone <vinodkone@apache.org>
> >>>> wrote:
> >>>>>>> Why hyphens? Most of the files in our repo use underscores.
I would
> >>>> like
> >>>>>> us
> >>>>>>> to be consistent on how we name files in the repo.
> >>>>>>>
> >>>>>>> On Thu, Feb 11, 2016 at 1:40 PM, Kevin Klues <klueska@gmail.com>
> >>>> wrote:
> >>>>>>>
> >>>>>>>> I prefer hyphens as well....
> >>>>>>>>
> >>>>>>>> On Thu, Feb 11, 2016 at 1:28 PM, Jojy Varghese <
> >> jojy@mesosphere.io>
> >>>>>> wrote:
> >>>>>>>>> hyphen++. Is google friendly apparently.  Also less
keys to press
> >>> :)
> >>>>>>>>>
> >>>>>>>>> -Jojy
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>> On Feb 11, 2016, at 12:43 PM, Greg Mann <greg@mesosphere.io>
> >>> wrote:
> >>>>>>>>>>
> >>>>>>>>>> +1
> >>>>>>>>>>
> >>>>>>>>>> On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone
<
> >>> vinodkone@apache.org>
> >>>>>>>> wrote:
> >>>>>>>>>>
> >>>>>>>>>>> Some the scripts in the "support" directory
have dashes ("-")
> >> in
> >>>>>> their
> >>>>>>>>>>> names (e.g., apply-review.sh, apply-reviews.py),
whereas some
> >>> have
> >>>>>>>>>>> underscores ("_") (e.g., docker_build.sh,
mesos_split.py).
> >>>>>>>>>>>
> >>>>>>>>>>> This is really confusing and we should stick
with one style. I
> >>>>>> propose
> >>>>>>>> to
> >>>>>>>>>>> change all them to use underscores. I will
make sure the CI
> >> jobs
> >>>> are
> >>>>>>>>>>> updated accordingly.
> >>>>>>>>>>>
> >>>>>>>>>>> Any objections?
> >>>>>>>>>>>
> >>>>>>>>>>> Thanks,
> >>>>>>>>>>> Vinod
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> ~Kevin
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> ~Kevin
> >>>
> >>>
> >>> --
> >>> Best Regards,
> >>> Haosdent Huang
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message