Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
MIME-Version: 1.0
In-Reply-To: <CAKgKkU6JT5WQS28e0YYsdR59gguA9w4x4L-Z2GKDoHOSg5Y2PA@mail.gmail.com>
References: <CAKgKkU6JT5WQS28e0YYsdR59gguA9w4x4L-Z2GKDoHOSg5Y2PA@mail.gmail.com>
From: tommy xiao <xiaods@gmail.com>
Date: Fri, 16 Dec 2016 05:31:02 +0800
Message-ID: <CAJA-XLNSjBq4AiE45fgLqR+kF+xW-4hk9gSDFu8-g_gzmXQ23g@mail.gmail.com>
Subject: Re: thread_local supported on Apple
To: dev <dev@mesos.apache.org>
Content-Type: multipart/alternative; boundary=94eb2c1923089753e50543b92b39
archived-at: Thu, 15 Dec 2016 21:31:13 -0000

--94eb2c1923089753e50543b92b39
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

+1

2016-12-15 7:27 GMT+08:00 Joris Van Remoortere <joris@mesosphere.io>:

> The time has come and we finally have `thread_local` support in the Apple
> tool chain:
> https://developer.apple.com/library/content/releasenotes/
> DeveloperTools/RN-Xcode/Introduction.html
>
> In our code base we have a special exception for Apple that defines our
> thread local to be `__thread` rather than the c++11 standard
> `thread_local`.
> https://github.com/apache/mesos/blob/812e5e3d4e4d9e044a1cfe6cc7eaab
> 10efb499b6/3rdparty/stout/include/stout/thread_local.hpp
>
> A consequence of using `__thread` on Apple is that initializers for threa=
d
> locals are required to be constant expressions. This is not the case for
> the c++11 standard `thread_local`.
>
> I would like to propose that we remove this exception on the Apple platfo=
rm
> now that the Apple toolchain supports the c++11 standard.
>
> As I am not a common user of the Apple development experience I would lik=
e
> to ask for some input from the community as to whether requiring this
> toolchain update is acceptable, and if we need a deprecation period or if
> we can just make this change now.
>
> I am leaning towards no deprecation period as I am not aware of productio=
n
> environments running on systems that define `__APPLE__`.
> =E2=80=94
> *Joris Van Remoortere*
> Mesosphere
>


--=20
Deshi Xiao
Twitter: xds2000
E-mail: xiaods(AT)gmail.com

--94eb2c1923089753e50543b92b39--