mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vi...@mesosphere.io>
Subject Re: Choice between LOG(FATAL) and EXIT(EXIT_FAILURE)
Date Fri, 16 Sep 2016 21:17:28 GMT
We typically used LOG(FATAL) when we were interested in the stack trace. If
not, we preferred to use EXIT(EXIT_FAILURE). While that was the original
intention, not sure if we have been following that distinction diligently.

Separately, we should fix EXIT to log at ERROR level instead of just
printing to to stderr.

On Tue, Aug 30, 2016 at 10:42 AM, Zhitao Li <zhitaoli.cs@gmail.com> wrote:

> Hi,
>
> Can someone explain better about when we should use LOG(FATAL) and when
> EXIT(EXIT_FAILURE) in Mesos codebase?
>
> One thing is that EXIT(EXIT_FAILURE) does not seem to leave anything in the
> level separated GLOG files so it could be mysterious to people who relies
> on that for debugging issues.
>
> I see we have about 100 call sites to LOG(FATAL) and 200 call sites
> to EXIT(EXIT_FAILURE) at the moment.
>
> Many thanks!
>
> --
> Cheers,
>
> Zhitao Li
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message