mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tuan-Anh Hoang-Vu <hvtuan...@gmail.com>
Subject Re: MESOS-5731 Add metric types to GetMetrics v1 api
Date Tue, 12 Jul 2016 02:05:20 GMT
I've pushed 4 review requests for this issue:

https://reviews.apache.org/r/49936/
https://reviews.apache.org/r/49937/
https://reviews.apache.org/r/49938/
https://reviews.apache.org/r/49939/

@Benjamin: I'm not sure I understand what you mean. Some of current Timers
have `statistics` to calculate count, min, max, p50, p95, ... so
technically they are already Histograms?


On Mon, Jul 11, 2016 at 1:44 PM, Benjamin Mahler <bmahler@apache.org> wrote:

> Have you considered introducing 'histograms' rather than 'timers'? Our
> Timers are just a special case of a histogram. For example, you could have
> a histogram of response sizes.
>
> On Fri, Jul 8, 2016 at 3:32 PM, Tuan-Anh Hoang-Vu <hvtuananh@gmail.com>
> wrote:
>
> > Hi all,
> >
> > I've finished implementing and testing this issue
> > https://issues.apache.org/jira/browse/MESOS-5731 and would like to find
> a
> > shepherd for my patch.
> >
> > Should I go ahead and submit the patch?
> >
> > Following Vinod's suggestion, I've changed Response::GetMetrics in
> > master.proto and v1/master.proto from
> >
> >   message GetMetrics {
> >     repeated Metric metrics = 1;
> >   }
> >
> > to
> >
> >   message GetMetrics {
> >     repeated Metric counters = 1;
> >     repeated Metric gauges = 2;
> >     repeated Metric timers = 3;
> >   }
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message