Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
From: "Hegner, Travis" <THegner@trilliumit.com>
To: "dev@mesos.apache.org" <dev@mesos.apache.org>
Subject: Shephard Reqeust: patch for MESOS-4370
Thread-Topic: Shephard Reqeust: patch for MESOS-4370
Thread-Index: AdFd7VSv/ZdNeUluRY+UG3Ga+kPxzg==
Date: Tue, 2 Feb 2016 19:18:35 +0000
Message-ID: 
 <DM2PR10MB00755CB4B9E458BCA4636397D1DF0@DM2PR10MB0075.namprd10.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative;
	boundary="_000_DM2PR10MB00755CB4B9E458BCA4636397D1DF0DM2PR10MB0075namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2016 19:18:35.9673
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: df6b236d-056d-416a-8f5f-f2e8e1a0238d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR10MB0073

--_000_DM2PR10MB00755CB4B9E458BCA4636397D1DF0DM2PR10MB0075namp_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hello All,

I am requesting a review of a patch to MESOS-4370. Here are all of the pert=
inent links:

https://issues.apache.org/jira/browse/MESOS-4370
https://reviews.apache.org/r/43093/
https://github.com/apache/mesos/pull/90

I have tagged Benjamin Hindman as a reviewer already on the review board as=
 he was listed as the maintainer of the Docker containerizer. I have not ha=
d any previous contact with him. My apologies if this is bad etiquette.

The patch eliminates the use of the deprecated "NetworkSettings.IPAddress" =
field in the docker inspect output, and replaces it with using the appropri=
ate "NetworkSettings.Networks.<name>.IPAddress" field, where <name> is the =
name of the network as it was passed to the last "--net <name>" on the dock=
er run command. The network name is available and queried from the "HostCon=
fig.NetworkMode" field in the inspect output.

Thanks,
Travis Hegner

--_000_DM2PR10MB00755CB4B9E458BCA4636397D1DF0DM2PR10MB0075namp_--