Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAOW5sYa4L4Ab_jYpNf-b1n6PXqaSgc3Lz7QSEZ_mcPWnjNsbmw@mail.gmail.com>
References: 
 <CAOW5sYZ5Pck8sb0nfuL5kqhUrYO8QPvHmV8XQ_NjNCYD5NjcgA@mail.gmail.com>
	<CA+-zrRLTjRmr3+LLT2krJ=Nzn9UOFDNMUpvsD2tMcDp1=sUtSQ@mail.gmail.com>
	<CAGmKMfV2WGxNYi3Tb5J71gMK1x_G=Opr+x3ZbGBcPChsP8msFQ@mail.gmail.com>
	<CAFGf3d7AdPfe0Fbu3JwO66G-a_Q882UrHcFb-CyCr4h-W5grew@mail.gmail.com>
	<CAOW5sYa4L4Ab_jYpNf-b1n6PXqaSgc3Lz7QSEZ_mcPWnjNsbmw@mail.gmail.com>
Date: Thu, 18 Feb 2016 13:59:53 -0500
Message-ID: 
 <CANtK1_WVGDoWXygJ0uBXBvMrOQrvXsYXMfdwMFwfkDVunGrLhg@mail.gmail.com>
Subject: Re: Enable compiler optimization by default?
From: Joris Van Remoortere <joris.van.remoortere@gmail.com>
To: dev@mesos.apache.org
Content-Type: multipart/alternative; boundary=001a11416af8c75db3052c0ff887

--001a11416af8c75db3052c0ff887
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

+1 (binding)
with the condition that we fix the flag mixing problem between CXXFLAGS and
--enable-optimize --enable-debug, even if it is to disallow it for now.
I want to avoid surprising behavior with implicit flags such as optimize:
passing irrelevant CXXFLAGS magically turns it into a debug build.

On Thu, Feb 18, 2016 at 1:27 PM, Neil Conway <neil.conway@gmail.com> wrote:

> Great! I created https://issues.apache.org/jira/browse/MESOS-4709 to
> track this issue.
>
> Neil
>
> On Thu, Feb 18, 2016 at 12:43 AM, Jan Schlicht <jan@mesosphere.io> wrote:
> > +1
> >
> > On Thu, Feb 18, 2016 at 2:34 AM, Klaus Ma <klaus1982.cn@gmail.com>
> wrote:
> >
> >> +1;
> >>
> >> So our CI will also update to use optimisation flags, right?  We need =
to
> >> highlight this in upgrade document to our user; I used to meet so
> strange
> >> behaviour after changing -O level.
> >>
> >> On Thu, Feb 18, 2016 at 8:51 AM James DeFelice <
> james.defelice@gmail.com>
> >> wrote:
> >>
> >> > +1
> >> > On Feb 17, 2016 7:24 PM, "Neil Conway" <neil.conway@gmail.com> wrote=
:
> >> >
> >> > > Hi folks,
> >> > >
> >> > > At present, Mesos defaults to compiling with "-O0"; to enable
> compiler
> >> > > optimizations, the user needs to specify "--enable-optimize".
> >> > >
> >> > > I'd like to propose we change the default, for a few reasons:
> >> > >
> >> > > (1) The autoconf default for CFLAGS/CXXFLAGS is "-O2 -g".
> Anecdotally,
> >> > > I think most software packages compile with a reasonable level of
> >> > > optimizations enabled by default.
> >> > >
> >> > > (2) I think we should make the default configure flags appropriate
> for
> >> > > end-users (rather than Mesos developers): developers will be
> familiar
> >> > > enough with Mesos to tune the configure flags according to their o=
wn
> >> > > preferences.
> >> > >
> >> > > (3) The performance consequences of not enabling compiler
> >> > > optimizations can be pretty severe: 5x in a benchmark I just ran,
> and
> >> > > we've seen between 2x and 30x (!) performance differences for some
> >> > > real-world workloads.
> >> > >
> >> > > Neil
> >> > >
> >> >
> >> --
> >>
> >> Regards,
> >> ----
> >> Da (Klaus), Ma (=E9=A9=AC=E8=BE=BE), PMP=C2=AE | Advisory Software Eng=
ineer
> >> IBM Platform Development & Support, STG, IBM GCG
> >> +86-10-8245 4084 | madaxa@cn.ibm.com | http://k82.me
> >>
> >
> >
> >
> > --
> > *Jan Schlicht*
> > Distributed Systems Engineer, Mesosphere
>

--001a11416af8c75db3052c0ff887--