Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
MIME-Version: 1.0
In-Reply-To: <8B78B3D5-00DD-40D5-98DB-04DF26D05C69@gmail.com>
References: <JIRA.12931523.1452879142000@Atlassian.JIRA>
	<JIRA.12931523.1452879142679@arcas>
	<JIRA.12931523.1452879142000.123847.1452879160250@Atlassian.JIRA>
	<0BD032B2-B4CA-433B-86AC-EC47DE96FE3B@gmail.com>
	<CAMHxVRG2WEjo2eabT=q=aKmO0CMoWHvsWYZ6KKaZ2Vt73rdfcg@mail.gmail.com>
	<8B78B3D5-00DD-40D5-98DB-04DF26D05C69@gmail.com>
Date: Mon, 1 Feb 2016 17:05:49 -0800
Message-ID: 
 <CAMHxVRG2YHeGO14GAMH-e1p=wZNnLb7C2v3KGF0Nc_iJaZB-0A@mail.gmail.com>
Subject: Re: [jira] [Created] (MESOS-4397) Rename ContainerPrepareInfo to
 ContainerLaunchInfo for isolators.
From: Jie Yu <yujie.jay@gmail.com>
To: dev@mesos.apache.org
Cc: issues@mesos.apache.org
Content-Type: multipart/alternative; boundary=001a1130cf262e6c4d052abf1afe

--001a1130cf262e6c4d052abf1afe
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

James,

You probably need to use ifdef on mesos version. For example:
https://github.com/emccode/mesos-module-dvdi/blob/master/isolator/isolator/=
docker_volume_driver_isolator.cpp#L127

The whole point of the recent change is to make sure we don't have to those
ifdef in the future (by using protobufs).

- Jie

On Mon, Feb 1, 2016 at 4:50 PM, James Peach <jorgar@gmail.com> wrote:

>
> > On Feb 1, 2016, at 4:27 PM, Jie Yu <yujie.jay@gmail.com> wrote:
> >
> > James,
> >
> > The above change didn't touch the allocator interface. Can you give us
> more
> > information here?
>
> sorry I meant to say "isolator" :)
>
> bash-4.1$ make
> ...
> src/isolator.cc:184:36: error: =E2=80=98ContainerPrepareInfo=E2=80=99 is =
not a member of
> =E2=80=98mesos::slave=E2=80=99
>      virtual process::Future<Option<mesos::slave::ContainerPrepareInfo> >
> prepare(
>                                     ^
> src/isolator.cc:184:36: error: =E2=80=98ContainerPrepareInfo=E2=80=99 is =
not a member of
> =E2=80=98mesos::slave=E2=80=99
> src/isolator.cc:184:70: error: template argument 1 is invalid
>      virtual process::Future<Option<mesos::slave::ContainerPrepareInfo> >
> prepare(
>                                                                       ^
> src/isolator.cc:184:72: error: template argument 1 is invalid
>      virtual process::Future<Option<mesos::slave::ContainerPrepareInfo> >
> prepare(
>
>
>
> >
> > - Jie
> >
> > On Mon, Feb 1, 2016 at 4:15 PM, James Peach <jorgar@gmail.com> wrote:
> >
> >> This is source incompatible for allocator modules. Can anyone suggest
> how
> >> to build the same allocator module code against multiple Mesos version=
s?
> >>
> >>
> >>> On Jan 15, 2016, at 9:32 AM, Jie Yu (JIRA) <jira@apache.org> wrote:
> >>>
> >>> Jie Yu created MESOS-4397:
> >>> -----------------------------
> >>>
> >>>            Summary: Rename ContainerPrepareInfo to ContainerLaunchInf=
o
> >> for isolators.
> >>>                Key: MESOS-4397
> >>>                URL: https://issues.apache.org/jira/browse/MESOS-4397
> >>>            Project: Mesos
> >>>         Issue Type: Task
> >>>           Reporter: Jie Yu
> >>>
> >>>
> >>> The name "ContainerPrepareInfo" does not really capture the purpose o=
f
> >> this struct. ContainerLaunchInfo better captures the purpose of this
> >> struct. ContainerLaunchInfo is returned by the isolator 'prepare'
> function.
> >> It contains information about how a container should be launched (e.g.=
,
> >> environment variables, namespaces, commands, etc.). The information
> will be
> >> used by the Mesos Containerizer when launching the container.
> >>>
> >>>
> >>>
> >>> --
> >>> This message was sent by Atlassian JIRA
> >>> (v6.3.4#6332)
> >>
> >>
>
>

--001a1130cf262e6c4d052abf1afe--