Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 62D831898A for ; Wed, 11 Nov 2015 00:57:47 +0000 (UTC) Received: (qmail 80172 invoked by uid 500); 11 Nov 2015 00:57:47 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 80091 invoked by uid 500); 11 Nov 2015 00:57:47 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 80079 invoked by uid 99); 11 Nov 2015 00:57:46 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Nov 2015 00:57:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4573A1809C1 for ; Wed, 11 Nov 2015 00:57:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.88 X-Spam-Level: ** X-Spam-Status: No, score=2.88 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id hDm650O-AIgW for ; Wed, 11 Nov 2015 00:57:38 +0000 (UTC) Received: from mail-yk0-f177.google.com (mail-yk0-f177.google.com [209.85.160.177]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id E88D420BD8 for ; Wed, 11 Nov 2015 00:57:37 +0000 (UTC) Received: by ykdv3 with SMTP id v3so25858362ykd.0 for ; Tue, 10 Nov 2015 16:57:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=e+GFHOLZqOCwtbRyI9LcG8OOd29lz9cnCqKryMpcxNM=; b=vIx8rsDZf78S+LftdhRcNcVcCl5JRSkO5Q/5E0cEPFRHIvNzPtzBgEcIr+iZubJ4I/ SFcN00Mbovuh+qcBz4lPp2yfo/gDs7obQiza12zOXbXsawhkraOERXp1lAMKmAFgySSh 4sTe/uDJ9POtDb4EpozuWO5VbHxviyOtI5/VQ1QLRn36Ru/WpJRXkY4H4/p6ChvAtrGm uxdT1Jl2YU+XUEC0oRtUpnbezUOROlwnDr8mWbmaQpTl49s94+8zA0jjGHHUfTj9d8Jj HB44MtRiF1wAWcTdXUyF64AxzMl0/1cDaguKfvgPOFbY2AxCzwFuG3UxzcRa6wTjdYkP Ra2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=e+GFHOLZqOCwtbRyI9LcG8OOd29lz9cnCqKryMpcxNM=; b=ESuNrxzSaxVuMZyH5vx311LnZUHJNE03fu5o1AmpZ1/kUNEpztl8Z9qyMF5N+nuXFm I/tu1uYAhKqEpcDaTc6zqWL+8Kk+awJzbJggFNuuDkP4U8r53KKr56yy17EkNAw6MdZH R96Elmf/uHOZBLCSVQqkK1Ohh/vwU5PeOx9yBl+zXgQ/ueuprGb0kdW++n5oeDJi5uLW aRqcjEwHYohBIN0s1A77KjmfHffB47jcXGBZF9DT+M7VYwzFWYslWqy5ukC8Q+fht781 rQMebzFtdkjixVj7XI/beotPL1kiE5TW58qhO1M33Vjip/LwKSktLc8zmcht8RRVCDWD vbWw== X-Received: by 10.129.87.132 with SMTP id l126mr6694043ywb.251.1447203456933; Tue, 10 Nov 2015 16:57:36 -0800 (PST) Received: from mail-yk0-f177.google.com (mail-yk0-f177.google.com. [209.85.160.177]) by smtp.gmail.com with ESMTPSA id m197sm7620995ywd.23.2015.11.10.16.57.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 16:57:36 -0800 (PST) Received: by ykdv3 with SMTP id v3so25857943ykd.0 for ; Tue, 10 Nov 2015 16:57:36 -0800 (PST) X-Gm-Message-State: ALoCoQkWqKWPWQs8EEAwst3MGu+ldzGekFdEJW1Xfub7rMf6OYiZZdlOCMJgPoLgd7no6nJ4WhXy MIME-Version: 1.0 X-Received: by 10.129.81.6 with SMTP id f6mr6205114ywb.271.1447203456261; Tue, 10 Nov 2015 16:57:36 -0800 (PST) Received: by 10.31.155.71 with HTTP; Tue, 10 Nov 2015 16:57:36 -0800 (PST) In-Reply-To: <6D87825F-D02B-44A7-9743-FD9F59B1F45C@duedil.com> References: <6D87825F-D02B-44A7-9743-FD9F59B1F45C@duedil.com> Date: Tue, 10 Nov 2015 16:57:36 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Fetcher refactor proposal From: Jie Yu To: dev Content-Type: multipart/alternative; boundary=001a1146412aeddbd00524394f58 --001a1146412aeddbd00524394f58 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tom, I don't have immediate plan to replace CommandInfo::URI (with executable/extract bits) with URI (in the doc), at least for now. The existing Fetcher will still perform extraction, chown, etc. for now (eventually, though I think those logics should be moved to slave/containerizer). The existing Fetcher can download the artifacts by leveraging the new uri::Fetcher interface (need a little refactor). On Tue, Nov 10, 2015 at 4:44 PM, Tom Arnfeld wrote: > This looks like a great change, btw! > > I have a quick question, how does this change affect things like the > executable/extract bits that are available in the existing fetcher? Would > that logic move outside of the fetcher itself, or would it live on the UR= I? > > I=E2=80=99m not sure if I=E2=80=99ve missed something in the design doc a= bout this, but it > came to mind=E2=80=A6 > > Tom. > > > On 10 Nov 2015, at 23:45, Jie Yu wrote: > > > > Hi, > > > > Fetcher was originally designed to fetch CommandInfo::URIs (e.g., > executor > > binary) for executors/tasks. A recent refactor (MESOS-336 > > ) added caching > support to > > the fetcher. The recent work on filesystem isolation/unified > containerizer ( > > MESOS-2840 ) requires > > Mesos to fetch filesystem images (e.g., APPC/DOCKER images) as well. Th= e > > natural question is: can we leverage the fetcher to fetch those > filesystem > > images (and cache them accordingly)? Unfortunately, the existing fetche= r > > interface is tightly coupled with CommandInfo::URIs for executors/tasks= , > > making it very hard to be re-used to fetch/cache filesystem images. > > > > Another motivation for the refactor is that we want to extend the fetch= er > > to support more types of schemes. For instance, we want to support magn= et > > URI to enable p2p fetching. This is in fact quite important for > operating a > > large cluster (MESOS-3596 < > https://issues.apache.org/jira/browse/MESOS-3596>). > > The goal here is to allow fetcher to be extended (e.g., using modules) = so > > that operators can add custom fetching support. > > > > I proposed a solution in this doc > > < > https://docs.google.com/document/d/1p8tmQrGtxG6keZVo19gvHPr9WHxeny6PHTVof= cLWqco/edit?usp=3Dsharing > >. > > The main idea is to decouple artifacts fetching from artifacts cache > > management. We can make artifacts fetching extensible (e.g. to support > p2p > > fetching), and solve the cache management part later. > > > > Let me know your thoughts! Thanks! > > > > - Jie > > --001a1146412aeddbd00524394f58--