Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3E62D18937 for ; Mon, 2 Nov 2015 19:27:06 +0000 (UTC) Received: (qmail 80840 invoked by uid 500); 2 Nov 2015 19:27:05 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 80748 invoked by uid 500); 2 Nov 2015 19:27:05 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 80736 invoked by uid 99); 2 Nov 2015 19:27:04 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Nov 2015 19:27:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 57E17C094C for ; Mon, 2 Nov 2015 19:27:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.901 X-Spam-Level: ** X-Spam-Status: No, score=2.901 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=mesosphere.io Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id F70-2FToi33r for ; Mon, 2 Nov 2015 19:26:54 +0000 (UTC) Received: from mail-ob0-f199.google.com (mail-ob0-f199.google.com [209.85.214.199]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id 20FAF42ABE for ; Mon, 2 Nov 2015 19:26:54 +0000 (UTC) Received: by oblt1 with SMTP id t1so128593271obl.2 for ; Mon, 02 Nov 2015 11:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mesosphere.io; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=i1xM1mhfkMMpn7rEh2awLE1sElSQMJukYIrblDZYT3o=; b=nXQkpntvy9sJ4NTG2cup/FjsZd3LyEw2BnCeaF0p1I98GeOq9Qgf/XLMatJDm942ta 6PSXy9cv0skB+zpwnP8WPXvWch+EIf3GO0lRtyXBeoYG72y3cgDhEm0cDbCsbNq65/LN nQgtv+OEXpAAc7BLq9J6Aq0FIAeNPqqwOaehM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=i1xM1mhfkMMpn7rEh2awLE1sElSQMJukYIrblDZYT3o=; b=j5prm+mJJP3HbixHq957f8rTrUgMWk8HwlNxgh+EGOKo6Bx5zAylZzlSRU+ByQO6Zj KlILWJgciiZvSoAHdEBHVai+tj4uZvZnesPrNTSm4WLZ6CxUNq0ymQ/3BZ/QFTE2+JG8 ps3/7va8s31TeT9s0rg3YEG2OQkHMjd4zWNNpnAS1dsGZUUFx77ACqT4IBus/WB5TGBz c164srz7GtgvmmMnCP3xWX2iX4HlIwdHudueker1RLu7IIz26VCinzyKG8m9SspgYQoG uqoVBEWqpkqH31XiS5mOBKjMiDxJc2XvG35Iz9dNiJydHp5il2Uq2k5vcJTDtKqE1L15 3Fcw== X-Gm-Message-State: ALoCoQkWzAmunyiKxgCK3DZDF0jEEtTT9EqtpHiN0kS7VZSB3eOcNp1QQy6l38IXEP3p+WYDEvjJ X-Received: by 10.202.176.66 with SMTP id z63mr14918436oie.15.1446492406788; Mon, 02 Nov 2015 11:26:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.92.3 with HTTP; Mon, 2 Nov 2015 11:26:27 -0800 (PST) In-Reply-To: References: From: Kapil Arya Date: Mon, 2 Nov 2015 14:26:27 -0500 Message-ID: Subject: Re: Backticks in comments To: dev Content-Type: multipart/alternative; boundary=001a113d636813e50e052393c2ea --001a113d636813e50e052393c2ea Content-Type: text/plain; charset=UTF-8 +1 for backticks. Also allows us to differentiate ordinary string literals like names, etc., from code. On Mon, Nov 2, 2015 at 2:18 PM, Marco Massenzio wrote: > +1 > > I much favor using backticks everywhere for consistency, since (as you > correctly pointed out) our Doxygen style requires that. > Hopefully, over time, we will have the whole codebase consistent again > (also an invite to folks, if you touch the code, to update comments > accordingly). > > BTW - unfortunately, Jira's markdown does not support backticks IIRC, but > {{ }} to demarcate 'fixed font' in paragraphs (and {code} or {noformat} > blocks for code snippets). > > (RB uses "generally-accepted" markdown, though, so that's good!) > > Thanks for raising awareness about this, Greg! > > -- > *Marco Massenzio* > Distributed Systems Engineer > http://codetrips.com > > On Mon, Nov 2, 2015 at 10:38 AM, Alex Clemmer > > wrote: > > > +1. Additional note is that this is now the de facto syntax for code > > snippets on the rest of our tools, too, including RB and JIRA. > > > > On Mon, Nov 2, 2015 at 10:32 AM, Greg Mann wrote: > > > Hey folks! > > > I wanted to bring up a style issue that I noticed recently. In some > > > comments in the codebase, backticks are used to quote code excerpts and > > > object names, while in other comments, single quotes are used. This > > doesn't > > > seem to be documented in our style guide (nor in Google's), and I think > > it > > > would be a good idea to establish a policy on this and document it, so > > that > > > we can avoid wasted review cycles related to this in the future. > > > > > > It's likely that the backtick convention began because Doxygen will > > render > > > backtick-enclosed text in monospace, and for this reason I would > propose > > > that we consistently use backticks to quote code excerpts and object > > names > > > in comments from now on. What does everyone else think? > > > > > > Cheers, > > > Greg > > > > > > > > -- > > Alex > > > > Theory is the first term in the Taylor series of practice. -- Thomas M > > Cover (1992) > > > --001a113d636813e50e052393c2ea--