Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Received-SPF: pass (nike.apache.org: domain of benjamin.mahler@gmail.com
 designates 209.85.160.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <968A3D58-5BC4-4BE0-9FC2-089836C71A81@me.com>
References: <2B3A80DD-3965-4922-A7DE-1E621C2CB5A0@mesosphere.io>
 <968A3D58-5BC4-4BE0-9FC2-089836C71A81@me.com>
From: Benjamin Mahler <benjamin.mahler@gmail.com>
Date: Wed, 17 Jun 2015 11:16:13 -0700
Message-ID: 
 <CA+8RcoTxR8uVdeEnvEGWJXbXe3ax3x6h4aQ=tZGjM2Pc7pp1mQ@mail.gmail.com>
Subject: Re: Style guide for std::move
To: dev <dev@mesos.apache.org>
Content-Type: multipart/alternative; boundary=001a113a80f6e25d5f0518bab088

--001a113a80f6e25d5f0518bab088
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Also, do we want to allow a re-assignment after a move to re-use the object=
?

Just some food for thought, have you explored extending Option to capture
this?

Option<vector<int>> v {1, 2, 3, 4};
foo(v.move());
v.isSome(); // false
v =3D {1, 2, 3, 4};
v.isSome() // true

On Wed, Jun 17, 2015 at 7:19 AM, Till Toenshoff <toenshoff@me.com> wrote:

> +1 for 1. =E2=80=9Ctreat it like a deleted pointer=E2=80=9D
>
>
> > On Jun 12, 2015, at 4:21 PM, Alexander Rojas <alexander@mesosphere.io>
> wrote:
> >
> > Hey guys, there have been questions on how to deal with std::move in th=
e
> code. Right now our style guide says nothing about it, but there is no
> consensus in the reviews. The problem with std::move is that for all
> standard library functions that accept rvalue references as parameters ar=
e
> guaranteed to leave the moved object in a valid but unspecified state (se=
e
> http://en.cppreference.com/w/cpp/utility/move <
> http://en.cppreference.com/w/cpp/utility/move>).
> >
> > The following are some ideas into how to deal with moved objects
> >
> > 1. Treat std::move as a delete and stop using it after the move
> >
> >       std::vector<int> v{1, 2, 3, 4};
> >       ..,
> >       foo(std::move(v)); // Don=E2=80=99t use
> >
> > 2. Always create explicitly an scope the object to be moved, with the
> first line being the definition of the object to be moved, and the last
> line of the scope the move itself.
> >
> >       if (bar()) {
> >         {
> >           std::vector<int> v{1, 2, 3};
> >           =E2=80=A6.
> >           foo(std::move(v));
> >         }
> >       }
> >
> > 3. Create a scope for the if no scope already exists following the rule=
s
> of 2):
> >
> >       if (bar()) {
> >         std::vector<int> v{1, 2, 3};
> >         =E2=80=A6.
> >         foo(std::move(v));
> >       }
> >
>
>

--001a113a80f6e25d5f0518bab088--