Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 81A0F17C18 for ; Tue, 21 Apr 2015 18:44:44 +0000 (UTC) Received: (qmail 75997 invoked by uid 500); 21 Apr 2015 18:44:44 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 75928 invoked by uid 500); 21 Apr 2015 18:44:44 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 75915 invoked by uid 99); 21 Apr 2015 18:44:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Apr 2015 18:44:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0864F1CE0CC; Tue, 21 Apr 2015 18:44:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6232381096927903513==" MIME-Version: 1.0 Subject: Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook. From: "Kapil Arya" To: "Niklas Nielsen" Cc: "Mesos ReviewBot" , "Adam B" , "mesos" Date: Tue, 21 Apr 2015 18:44:45 -0000 Message-ID: <20150421184445.2948.11995@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/29947/ X-Sender: "Kapil Arya" References: <20150417230922.4550.68495@reviews.apache.org> In-Reply-To: <20150417230922.4550.68495@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos --===============6232381096927903513== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/ ----------------------------------------------------------- (Updated April 21, 2015, 2:44 p.m.) Review request for mesos and Niklas Nielsen. Changes ------- Addressed Nik's comments. Bugs: MESOS-2226 https://issues.apache.org/jira/browse/MESOS-2226 Repository: mesos Description (updated) ------- There is currently no good way to synchronize between the test body and the hook code, so we wire a promise (owned by the test code). The technical debt is covered by the following JIRA issue: https://issues.apache.org/jira/browse/MESOS-2641 Diffs (updated) ----- src/examples/test_hook_module.cpp 2f2da1c5ef85af06c7f366d38ce5b64f39d0076f src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 Diff: https://reviews.apache.org/r/29947/diff/ Testing ------- make check Thanks, Kapil Arya --===============6232381096927903513==--