Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0ECD71737C for ; Wed, 15 Apr 2015 00:44:55 +0000 (UTC) Received: (qmail 57399 invoked by uid 500); 15 Apr 2015 00:44:54 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 57328 invoked by uid 500); 15 Apr 2015 00:44:54 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 57302 invoked by uid 99); 15 Apr 2015 00:44:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2015 00:44:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 970E91D9BDE; Wed, 15 Apr 2015 00:44:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3743921704653425812==" MIME-Version: 1.0 Subject: Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file. From: "Till Toenshoff" To: "Joris Van Remoortere" , "switched to 'mcypark'" , "Adam B" Cc: "mesos" , "Kapil Arya" , "Till Toenshoff" , "Mesos ReviewBot" , "Alexander Rukletsov" , "Joerg Schad" Date: Wed, 15 Apr 2015 00:44:55 -0000 Message-ID: <20150415004455.14115.76231@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Till Toenshoff" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/32850/ X-Sender: "Till Toenshoff" References: <20150414142011.31554.41610@reviews.apache.org> In-Reply-To: <20150414142011.31554.41610@reviews.apache.org> Reply-To: "Till Toenshoff" X-ReviewRequest-Repository: mesos-incubating --===============3743921704653425812== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32850/ ----------------------------------------------------------- (Updated April 15, 2015, 12:44 a.m.) Review request for mesos, Adam B, Joris Van Remoortere, and switched to 'mcypark'. Changes ------- Addressed most of Alex's comments. Bugs: MESOS-2584 https://issues.apache.org/jira/browse/MESOS-2584 Repository: mesos-incubating Description ------- Removing the process from the header is much cleaner and also fixes the linked clang 3.4.2 JIRA. Apart from that moving, no code is changed. Diffs (updated) ----- src/Makefile.am d15a373 src/authentication/cram_md5/authenticatee.hpp 55fac68 src/authentication/cram_md5/authenticatee.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32850/diff/ Testing ------- make check Thanks, Till Toenshoff --===============3743921704653425812==--