Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D010174E6 for ; Fri, 10 Apr 2015 17:36:31 +0000 (UTC) Received: (qmail 46092 invoked by uid 500); 10 Apr 2015 17:36:30 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 46019 invoked by uid 500); 10 Apr 2015 17:36:30 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 46002 invoked by uid 99); 10 Apr 2015 17:36:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Apr 2015 17:36:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 19E821D754B; Fri, 10 Apr 2015 17:36:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7043982306309812193==" MIME-Version: 1.0 Subject: Re: Review Request 32998: Split committer's guide into code reviewing and committing documents. From: "Vinod Kone" To: "Niklas Nielsen" , "Benjamin Hindman" , "Adam B" , "Jie Yu" , "Vinod Kone" Cc: "mesos" , "Ben Mahler" Date: Fri, 10 Apr 2015 17:36:32 -0000 Message-ID: <20150410173632.21893.89181@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/32998/ X-Sender: "Vinod Kone" References: <20150409003042.5637.56076@reviews.apache.org> In-Reply-To: <20150409003042.5637.56076@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos --===============7043982306309812193== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32998/#review79712 ----------------------------------------------------------- Ship it! docs/effective-code-reviewing.md s/a commits/commits/ docs/effective-code-reviewing.md s/recommend/recommended/ docs/effective-code-reviewing.md s/thourough/thorough/ - Vinod Kone On April 9, 2015, 12:30 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32998/ > ----------------------------------------------------------- > > (Updated April 9, 2015, 12:30 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2581 > https://issues.apache.org/jira/browse/MESOS-2581 > > > Repository: mesos > > > Description > ------- > > "Committer's Guide" was too generic. This names the documents after "what" the reader is looking for: doing effective reviews, and how to commit changes (for committers only). > > > Diffs > ----- > > docs/committers-guide.md c016ee9cb3290d7788ed258904547b59bbea4f11 > docs/committing.md PRE-CREATION > docs/effective-code-reviewing.md PRE-CREATION > docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea > > Diff: https://reviews.apache.org/r/32998/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Ben Mahler > > --===============7043982306309812193==--