Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============3292938500171655572=="
MIME-Version: 1.0
Subject: Review Request 32805: Terminated the perf subprocess once the parent
 exits.
From: "Jie Yu" <yujie.jay@gmail.com>
To: "Vinod Kone" <vinodkone@gmail.com>,
 "Ben Mahler" <benjamin.mahler@gmail.com>, "Ian Downes" <ian.downes@gmail.com>
Cc: "Jie Yu" <yujie.jay@gmail.com>, "mesos" <dev@mesos.apache.org>
Date: Fri, 03 Apr 2015 01:42:00 -0000
Message-ID: <20150403014200.16791.65976@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jie Yu" <noreply@reviews.apache.org>
Reply-To: "Jie Yu" <yujie.jay@gmail.com>

--===============3292938500171655572==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32805/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Bugs: MESOS-2462
    https://issues.apache.org/jira/browse/MESOS-2462


Repository: mesos


Description
-------

Terminated the perf subprocess once the parent exits.

The idea is to have a nanny process which installs a SIGTERM handler which will kill the process group (of course, we need to put the nanny and perf process to the same process group). We set the death signal of the nanny process to be SIGTERM. In that way, when slave exits, the nanny process will receive a SIGTERM, which will then kill all processes in the process group.


Diffs
-----

  src/linux/perf.cpp cad6c80e2a9608ff02fc2b8976efba52713dd5a8 

Diff: https://reviews.apache.org/r/32805/diff/


Testing
-------

sudo make check

I also manually verified it by terminating the slave while perf is in progress. The perf is killed immediately.


Thanks,

Jie Yu


--===============3292938500171655572==--