Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============4445720413217027586=="
MIME-Version: 1.0
Subject: Re: Review Request 31267: Added a test allocator module.
From: "Alexander Rukletsov" <rukletsov@gmail.com>
To: "Niklas Nielsen" <nik@qni.dk>, "Michael Park" <mcypark@gmail.com>,
 "Kapil Arya" <kapil@mesosphere.io>
Cc: "mesos" <dev@mesos.apache.org>,
 "Alexander Rukletsov" <rukletsov@gmail.com>,
 "Alexander Rojas" <alexander@mesosphere.io>
Date: Wed, 01 Apr 2015 10:46:15 -0000
Message-ID: <20150401104615.16791.48251@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alexander Rukletsov" <noreply@reviews.apache.org>
References: <20150327163653.1505.60211@reviews.apache.org>
In-Reply-To: <20150327163653.1505.60211@reviews.apache.org>
Reply-To: "Alexander Rukletsov" <rukletsov@gmail.com>

--===============4445720413217027586==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On March 27, 2015, 4:36 p.m., Alexander Rojas wrote:
> > src/tests/module.cpp, line 137
> > <https://reviews.apache.org/r/31267/diff/4-5/?file=903021#file903021line137>
> >
> >     You may need a `CHECK(modules != NULL)` or a log and return in the NULL case?

If you follow the invokation path, you'll see that modules is a stack variable (see `initModules()`) and can't be null. I agree this is not clear at the place where we use a pointer to it and may change in the future, but this is more a general question about the design decision that should go to @tillt. Pass by pointer was introduced in 
Commit: 7ee3b7b672a4d8fee4fe4eb5f0aa2e7e3bf6b049
Review: https://reviews.apache.org/r/31253
Author: Till Toenshoff <toenshoff@me.com>


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review78070
-----------------------------------------------------------


On March 27, 2015, 4:26 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31267/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 4:26 p.m.)
> 
> 
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2160
>     https://issues.apache.org/jira/browse/MESOS-2160
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test allocator module is a built-in HierarchicalDRFAllocator put in a module.
> 
> NOTE: Here we add harness code to load the module, tests will be wired up later in the patch stack.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7a06c7028eca8164b1f5fdea6a7ecd37ee6826bb 
>   src/examples/test_allocator_module.cpp PRE-CREATION 
>   src/tests/module.hpp 65e567f21744d9a2b07b8680d45bcd1ea47f9508 
>   src/tests/module.cpp b81144f56e94034feecf3a6a4992af078cf60a81 
> 
> Diff: https://reviews.apache.org/r/31267/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.9.5, CentOS 7.0)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


--===============4445720413217027586==--