mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu" <evelina.a.dumitre...@gmail.com>
Subject Re: Review Request 33329: Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error.
Date Tue, 21 Apr 2015 16:25:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33329/#review80984
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/33329/#comment131174>

    I wanted to say to keep the freeaddrinfo and initialize result with NULL


- Evelina Dumitrescu


On April 20, 2015, 7:16 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33329/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 7:16 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Evelina Dumitrescu, and Jie Yu.
> 
> 
> Bugs: mesos-2636
>     https://issues.apache.org/jira/browse/mesos-2636
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3622165af064a1f0a9d461af0e1d0d88a352d4a8

> 
> Diff: https://reviews.apache.org/r/33329/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message