mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 32859: Add Camel-case libprocess variable and method names sample.
Date Tue, 21 Apr 2015 02:26:49 GMT


> On April 7, 2015, 3:06 a.m., Joris Van Remoortere wrote:
> > Hi haosdent,
> > I added some higher level comments in the JIRA ticket for you :-)
> 
> Niklas Nielsen wrote:
>     haosdent, did you get a chance to take a look at Joris' comments? Do you need to
update the review request or what are our next steps?
> 
> haosdent huang wrote:
>     @nnielsen Yes? I also reply the comment. So I think the issue is not accepted, should
I discard this review?
> 
> Niklas Nielsen wrote:
>     Let's do that for now. Thanks for understanding!

Thank you


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32859/#review79117
-----------------------------------------------------------


On April 6, 2015, 9:19 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32859/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 9:19 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2576
>     https://issues.apache.org/jira/browse/MESOS-2576
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add Camel-case libprocess variable and method names sample.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libev.hpp e4a403d9e769c13182f26034e0dd1c4db92b04cb 
>   3rdparty/libprocess/src/libev.cpp 610dfb896ed8f9c00f9cf8fc8dbfc7d434f7d1e5 
>   3rdparty/libprocess/src/libev_poll.cpp 324e4dd950989f3717ca73fe48520ca3e518518f 
>   3rdparty/libprocess/src/process.cpp cf4e36489be2c6aa01e838c1c71383f248deab5b 
> 
> Diff: https://reviews.apache.org/r/32859/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message