mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 32844: Added SUBSCRIBE call and SUBSCRIBED event.
Date Mon, 20 Apr 2015 23:18:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32844/#review80855
-----------------------------------------------------------


Looks good. I asked below: why did the original code process (re-)registration messages when
we haven't detected a master?


include/mesos/scheduler/scheduler.proto
<https://reviews.apache.org/r/32844/#comment130970>

    Might help to have a hint pointing to the framework id semantics:
    
    ```
    SUBSCRIBE = 1;  // See 'framework_info' below.
    ```



src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/32844/#comment130971>

    Maybe just "Subscribed with ID X"?



src/examples/low_level_scheduler_pthread.cpp
<https://reviews.apache.org/r/32844/#comment130973>

    Ditto here.



src/master/master.cpp
<https://reviews.apache.org/r/32844/#comment130974>

    TODO for implementing this? I assume you held off because of the non-trivial streaming
related changes needed?



src/scheduler/scheduler.cpp
<https://reviews.apache.org/r/32844/#comment130975>

    This check considers set to `""` as unset, but the check above does not? (Where we check
for missing `FrameworkInfo.id` in the `Call`)



src/scheduler/scheduler.cpp
<https://reviews.apache.org/r/32844/#comment130976>

    Hm, should we re-phrase this? I don't know what it means :)



src/scheduler/scheduler.cpp
<https://reviews.apache.org/r/32844/#comment130979>

    This isn't yours, but is this right? We're looking at SUBSCRIBED events when the master
is `None`?


- Ben Mahler


On April 20, 2015, 8:03 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32844/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 8:03 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1127
>     https://issues.apache.org/jira/browse/MESOS-1127
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of REGISTER and REREGISTER we now just have SUBSCRIBE. Similarly, instead of
REGISTERED and REREGISTERED there is only SUBSCRIBED. This will simplify a scheduler's registration
semantics.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8 
>   src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997

>   src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d

>   src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc 
>   src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a 
>   src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 
> 
> Diff: https://reviews.apache.org/r/32844/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message