mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 32844: Added SUBSCRIBE call and SUBSCRIBED event.
Date Mon, 20 Apr 2015 20:02:40 GMT


> On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> > Looks good to me, mind update the design doc?

isabel has kindly agreed to update the doc by EOD.


> On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> > include/mesos/scheduler/scheduler.proto, line 37
> > <https://reviews.apache.org/r/32844/diff/1/?file=915065#file915065line37>
> >
> >     Does it make sense to pick up a new field id to avoid collisions? Same below
for `Subscribed` field and `Call` message.
> >     
> >     I see you do a batch update in the last patch in the sequence, just want to
confirm we do want to break it.

Yea, decided to break it since we haven't officially released the new API.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32844/#review79378
-----------------------------------------------------------


On April 3, 2015, 11:46 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32844/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 11:46 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1127
>     https://issues.apache.org/jira/browse/MESOS-1127
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of REGISTER and REREGISTER we now just have SUBSCRIBE. Similarly, instead of
REGISTERED and REREGISTERED there is only SUBSCRIBED. This will simplify a scheduler's registration
semantics.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8 
>   src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997

>   src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d

>   src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b 
>   src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a 
>   src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 
> 
> Diff: https://reviews.apache.org/r/32844/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message