mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 31666: Sent 'framework->usedResourcesBySlaveId' to allocator instead for 'addFramework'.
Date Wed, 15 Apr 2015 19:35:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31666/#review80257
-----------------------------------------------------------

Ship it!



src/master/allocator/mesos/hierarchical.hpp
<https://reviews.apache.org/r/31666/#comment130059>

    Should there be a TODO here related to what needs to be done?


- Ben Mahler


On April 15, 2015, 3:54 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31666/
> -----------------------------------------------------------
> 
> (Updated April 15, 2015, 3:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-2373
>     https://issues.apache.org/jira/browse/MESOS-2373
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Piped the master through by `s/framework->usedResources/framework->usedResourcesBySlaveId/`
> Lots of `s/Resources()/hashmap<SlaveID, Resources>()/` in `src/tests/hierarchical_allocator_tests.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/allocator.hpp 91f80501aa9bc733fd53f9cb1ac0f15949a74964 
>   src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f 
>   src/master/allocator/mesos/hierarchical.hpp 9f9a631ee52a3ab194e678f9be139e8dabc7f3db

>   src/master/master.cpp 44b0a0147f5354824d86332a67b30018634c9a36 
>   src/tests/hierarchical_allocator_tests.cpp 8861bf398e4bb17b0f74eab4f4af26202447ccef

>   src/tests/mesos.hpp 42e42ac425a448fcc5e93db1cef1112cbf5e67c4 
> 
> Diff: https://reviews.apache.org/r/31666/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message