mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.
Date Wed, 15 Apr 2015 00:44:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/
-----------------------------------------------------------

(Updated April 15, 2015, 12:44 a.m.)


Review request for mesos, Adam B, Joris Van Remoortere, and switched to 'mcypark'.


Changes
-------

Addressed most of Alex's comments.


Bugs: MESOS-2584
    https://issues.apache.org/jira/browse/MESOS-2584


Repository: mesos-incubating


Description
-------

Removing the process from the header is much cleaner and also fixes the linked clang 3.4.2
JIRA. Apart from that moving, no code is changed.


Diffs (updated)
-----

  src/Makefile.am d15a373 
  src/authentication/cram_md5/authenticatee.hpp 55fac68 
  src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/32850/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message