mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.
Date Wed, 15 Apr 2015 00:09:41 GMT


> On April 14, 2015, 7:22 p.m., Kapil Arya wrote:
> > src/authentication/cram_md5/authenticatee.cpp, lines 46-47
> > <https://reviews.apache.org/r/32850/diff/3/?file=922370#file922370line46>
> >
> >     According to our style guide, this is okay but we keep seeing issues being raised
about this. Should we just update the style guide instead?

The styleguide is IMHO unclear on this case as it proposes similar examples but only being
"ok". Definitely a case for an update suggestion.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80082
-----------------------------------------------------------


On April 14, 2015, 2:20 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 2:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 'mcypark'.
> 
> 
> Bugs: MESOS-2584
>     https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Removing the process from the header is much cleaner and also fixes the linked clang
3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message