mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.
Date Tue, 14 Apr 2015 18:17:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32850/#review80072
-----------------------------------------------------------



src/authentication/cram_md5/authenticatee.cpp
<https://reviews.apache.org/r/32850/#comment129844>

    Actually according to Google's styleguide this should be the first include, shouldn't
it?
    http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes
    
    I know we don't do that at other places but actually it would prevent a number of Alexs
comments (and be consistent with the styleguide)...


- Joerg Schad


On April 14, 2015, 2:20 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32850/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 2:20 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, and switched to 'mcypark'.
> 
> 
> Bugs: MESOS-2584
>     https://issues.apache.org/jira/browse/MESOS-2584
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Removing the process from the header is much cleaner and also fixes the linked clang
3.4.2 JIRA. Apart from that moving, no code is changed.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d15a373 
>   src/authentication/cram_md5/authenticatee.hpp 55fac68 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32850/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message