-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32984/#review79727
-----------------------------------------------------------
Ship it!
LGTM. Are you planning to add similar ones for java and python, because that's what framework
writers would be most intersted in. A TODO for now is fine. Alternatively, you can convert
the current example frameworks (cpp, java and python) to use persistent volumes instead of
writing new ones.
src/examples/persistent_volume_framework.cpp
<https://reviews.apache.org/r/32984/#comment129257>
s/launch/Launch/
s/volume/volume./
src/examples/persistent_volume_framework.cpp
<https://reviews.apache.org/r/32984/#comment129258>
s/restart/Restart/
s/finishes/finishes./
src/examples/persistent_volume_framework.cpp
<https://reviews.apache.org/r/32984/#comment129259>
s/terminate/Terminate/
src/examples/persistent_volume_framework.cpp
<https://reviews.apache.org/r/32984/#comment129261>
'break' here?
- Vinod Kone
On April 8, 2015, 7:08 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32984/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 7:08 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-2404
> https://issues.apache.org/jira/browse/MESOS-2404
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an example framework for testing persistent volumes.
>
>
> Diffs
> -----
>
> src/Makefile.am 9c01f5d6c692f835100e7cade928748cc4763cc8
> src/examples/persistent_volume_framework.cpp PRE-CREATION
> src/tests/examples_tests.cpp 5222b6d5e66736495b743367b5731bb9094410fd
> src/tests/persistent_volume_framework_test.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32984/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
|