mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 33057: Added secret check to CRAM-MD5 authenticatee.
Date Fri, 10 Apr 2015 07:16:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33057/#review79646
-----------------------------------------------------------

Ship it!


LGTM. Did you (manually) test the CRAM-MD5 authenticator/ee without a secret? Can we automate
that?


src/authentication/cram_md5/authenticatee.cpp
<https://reviews.apache.org/r/33057/#comment129169>

    What's the difference between returning a failure and returning `false`?


- Adam B


On April 9, 2015, 8:02 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33057/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 8:02 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-2608
>     https://issues.apache.org/jira/browse/MESOS-2608
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Updating authenticatee to check for secret within credential.
> 
> 
> Diffs
> -----
> 
>   src/authentication/cram_md5/authenticatee.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33057/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message