mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.
Date Thu, 09 Apr 2015 22:08:31 GMT


> On April 8, 2015, 6:44 p.m., Jie Yu wrote:
> > src/tests/cgroups_tests.cpp, lines 539-542
> > <https://reviews.apache.org/r/32955/diff/1/?file=920415#file920415line539>
> >
> >     Any reason you want to remove this?

Disabling it makes the subprocess hang and not return from increaseRSS so the test hangs too.

I could either change the method to not wait, or let the subprocess get killed; the latter
seems that it won't affecting testing the future.


- Chi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79395
-----------------------------------------------------------


On April 9, 2015, 10:08 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 10:08 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: mesos-2573
>     https://issues.apache.org/jira/browse/mesos-2573
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Simplified ROOT_CGROUPS_Listen test.
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef 
> 
> Diff: https://reviews.apache.org/r/32955/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message