mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 30961: Enabled label decorator to override.
Date Thu, 09 Apr 2015 00:31:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30961/#review79454
-----------------------------------------------------------

Ship it!


LGTM. Where's the JIRA/patch for updating the upgrades doc to explain the module API change?


src/examples/test_hook_module.cpp
<https://reviews.apache.org/r/30961/#comment128844>

    Unused? Or should you check that the value being removed is what you expect?



src/examples/test_hook_module.cpp
<https://reviews.apache.org/r/30961/#comment128845>

    label shadows label? Maybe oldLabel/newLabel? Then you can also reuse the `Label*` in
line 52 and 59 (`label_`)


- Adam B


On April 7, 2015, 5:57 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30961/
> -----------------------------------------------------------
> 
> (Updated April 7, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kapil Arya.
> 
> 
> Bugs: MESOS-2351
>     https://issues.apache.org/jira/browse/MESOS-2351
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d 
>   src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 
>   src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f 
>   src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b 
>   src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 
> 
> Diff: https://reviews.apache.org/r/30961/diff/
> 
> 
> Testing
> -------
> 
> make check (with modified VerifyMasterLaunchTaskHook test)
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message