mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 32700: Removed FrameworkID from FrameworkState.
Date Tue, 07 Apr 2015 17:00:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32700/
-----------------------------------------------------------

(Updated April 7, 2015, 1 p.m.)


Review request for mesos, Adam B and Niklas Nielsen.


Changes
-------

rebased


Bugs: MESOS-2559
    https://issues.apache.org/jira/browse/MESOS-2559


Repository: mesos


Description
-------

FrameworkState already has FrameworkInfo which will have a valid FrameworkID.

NOTE: This patch is only to be merged _ONLY_ after all the dependent patches have shipped,
i.e. after 0.23.0 (tracked here: https://issues.apache.org/jira/browse/MESOS-2561) has released.


Diffs (updated)
-----

  src/slave/containerizer/docker.cpp e83b912c707a3f2687b09a647a9ed248a940ea97 
  src/slave/containerizer/external_containerizer.cpp 1bbd61cb096771b7e4a1350079f79a20102e78f9

  src/slave/containerizer/mesos/containerizer.cpp fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748

  src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16 
  src/slave/state.hpp 31dfdd5a4b644f466756a712deded1b025a73c02 
  src/slave/state.cpp 35ce70b6702473a3100991372f3ba36bcad391c0 
  src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 

Diff: https://reviews.apache.org/r/32700/diff/


Testing
-------

make check.

TODO: Test for upgrade path.


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message