mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 32834: Modifiy gdb scripts error message to check gdb is installed.
Date Mon, 06 Apr 2015 05:36:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32834/#review78900
-----------------------------------------------------------

Ship it!


Trivial but helpful error message clarification. I suggested an alternate wording, but am
fine with this either way.


bin/gdb-mesos-local.sh.in
<https://reviews.apache.org/r/32834/#comment128001>

    Alternate wording: "Generated libtool doesn't appear to support gdb, or gdb is not installed."


- Adam B


On April 3, 2015, 3:01 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32834/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 3:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Cody Maloney, and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ran into a problem where gdb isn't installed and I see a error message saying generated
libtool doesn't support gdb. 
> Changed the error message to ask user to make sure gdb is also installed.
> 
> 
> Diffs
> -----
> 
>   bin/gdb-mesos-local.sh.in 72cfb68b4ff2ac796aa381cf6c49f6a4b83eb28b 
>   bin/gdb-mesos-master.sh.in f00af078bb9b8a6c3689d1ddd0db6efe38614d87 
>   bin/gdb-mesos-slave.sh.in e01325c59ed62eb2e0d6bdf24808fc3f0cd206ab 
>   bin/gdb-mesos-tests.sh.in 626fefe7d953bf226e6d5fb84c87a6f3d66f4da9 
> 
> Diff: https://reviews.apache.org/r/32834/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message