mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 32805: Terminated the perf subprocess once the parent exits.
Date Fri, 03 Apr 2015 21:29:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32805/
-----------------------------------------------------------

(Updated April 3, 2015, 9:29 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Bugs: MESOS-2462
    https://issues.apache.org/jira/browse/MESOS-2462


Repository: mesos


Description
-------

Terminated the perf subprocess once the parent exits.

The idea is to have a nanny process which installs a SIGTERM handler which will kill the process
group (of course, we need to put the nanny and perf process to the same process group). We
set the death signal of the nanny process to be SIGTERM. In that way, when slave exits, the
nanny process will receive a SIGTERM, which will then kill all processes in the process group.


Diffs
-----

  src/linux/perf.cpp cad6c80e2a9608ff02fc2b8976efba52713dd5a8 

Diff: https://reviews.apache.org/r/32805/diff/


Testing
-------

sudo make check

I also manually verified it by terminating the slave while perf is in progress. The perf is
killed immediately.


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message