mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 31776: Moved allocator to public headers.
Date Thu, 02 Apr 2015 18:23:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31776/#review78690
-----------------------------------------------------------

Ship it!



include/mesos/master/allocator.proto
<https://reviews.apache.org/r/31776/#comment127643>

    Since allocator is within the same Unix process as Master, what is the compatibility issue
here?



src/Makefile.am
<https://reviews.apache.org/r/31776/#comment127644>

    not yours, but can you kill the trailing white space here?


- Vinod Kone


On April 1, 2015, 2:25 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31776/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 2:25 p.m.)
> 
> 
> Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2160
>     https://issues.apache.org/jira/browse/MESOS-2160
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is required for out-of-tree allocator modules. RoleInfo protobuf message has to
be extracted into its own public proto file.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.proto PRE-CREATION 
>   src/Makefile.am 9c01f5d6c692f835100e7cade928748cc4763cc8 
>   src/local/local.hpp 0aa50ef4f44c347eca4b3a409f2a8d03ba321d82 
>   src/local/local.cpp 19083368212b24ce1afef3a5f91d48766d1cd55e 
>   src/master/allocator/allocator.hpp b67b8fddbd7a3fffc6fe24d5e77cd1db8cb6f69b 
>   src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f 
>   src/master/main.cpp 7cce3a0bb808a1cb7bac9acab31eb1c67a15ea9f 
>   src/master/master.hpp 05be911734b8d70c9fa5f3b4a275e8b610621fc5 
>   src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b 
>   src/messages/messages.proto 97c45c01dfcea38b1ae555c036d61e10c152c2c8 
>   src/tests/cluster.hpp a56b6541adcdebc5866571bbdbb6828df97b34ec 
>   src/tests/fault_tolerance_tests.cpp a637c32f004638a110390b22cf5b626e904097cf 
>   src/tests/hierarchical_allocator_tests.cpp 8861bf398e4bb17b0f74eab4f4af26202447ccef

>   src/tests/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302 
>   src/tests/master_authorization_tests.cpp ac79303645cc1af337b1dca8db244113d0ba6fce 
>   src/tests/master_slave_reconciliation_tests.cpp e60f601202fcdbb4cafac190e9b09ca6ce925260

>   src/tests/master_tests.cpp 2bfd0f8a20169649cff03509556b4cfa965a9837 
>   src/tests/mesos.hpp 0e98572a62ae05437bd2bc800c370ad1a0c43751 
>   src/tests/mesos.cpp 02cbb4b8cf1206d0f32d160addc91d7e0f1ab28b 
>   src/tests/rate_limiting_tests.cpp d5c00b8db30fc529bc984417a632cf99eb50eb28 
> 
> Diff: https://reviews.apache.org/r/31776/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS 10.9.5, CentOS 7.0)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message