mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 32742: Added command logging for processes running in slave's cgroup.
Date Wed, 01 Apr 2015 21:15:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742/#review78591
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/32742/#comment127484>

    ostringstream?
    
    Have you considered just building a set<string> and using strings::join("\n", commands)
below? Then you don't have to deal with the delimiters in the stringstream and the fact that
we're left with an extra newline at the end as a result.


- Ben Mahler


On April 1, 2015, 8:05 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32742/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 8:05 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Bugs: MESOS-2461
>     https://issues.apache.org/jira/browse/MESOS-2461
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added command logging for processes running in slave's cgroup.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 0f70ebafb0f5b16c560decc66e22a43a52732d09 
> 
> Diff: https://reviews.apache.org/r/32742/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message