mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Brett" <pau...@twopensource.com>
Subject Re: Review Request 32656: Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.
Date Wed, 01 Apr 2015 15:59:05 GMT


> On March 31, 2015, 11:38 p.m., Chi Zhang wrote:
> > src/tests/port_mapping_tests.cpp, lines 188-192
> > <https://reviews.apache.org/r/32656/diff/1/?file=910499#file910499line188>
> >
> >     having no output here isn't expected; why delay reporting it?

Having no output here is currently an expected behaviour.  If mesos-network-helper is called
with an invalid pid (for example, before a namespace has been created) then it generates no
output and returns with an error status.  I believe it would be better to always generate
valid JSON output, with a clear error indication if an error occurs.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32656/#review78432
-----------------------------------------------------------


On April 1, 2015, 3:44 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32656/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 3:44 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
>     https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactor statistics helper out of PortMappingIsolatorTest for easier reuse.
> 
> 
> Diffs
> -----
> 
>   src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 
> 
> Diff: https://reviews.apache.org/r/32656/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message