Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72DDD17E26 for ; Tue, 31 Mar 2015 20:30:52 +0000 (UTC) Received: (qmail 15012 invoked by uid 500); 31 Mar 2015 20:30:49 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 14942 invoked by uid 500); 31 Mar 2015 20:30:49 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 14927 invoked by uid 99); 31 Mar 2015 20:30:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Mar 2015 20:30:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A6AF71D7029; Tue, 31 Mar 2015 20:30:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5467500025047892360==" MIME-Version: 1.0 Subject: Re: Review Request 32584: Do not pass FrameworkID to Framework constructor in Master/Slave. From: "Kapil Arya" To: "Niklas Nielsen" , "Adam B" Cc: "mesos" Date: Tue, 31 Mar 2015 20:30:47 -0000 Message-ID: <20150331203047.16792.85572@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/32584/ X-Sender: "Kapil Arya" References: <20150330060857.16791.5317@reviews.apache.org> In-Reply-To: <20150330060857.16791.5317@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos --===============5467500025047892360== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 30, 2015, 2:08 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 3874-3876 > > > > > > When/how do you plan to change the checkpointed FrameworkState.id and info over the next few releases? Created a new RR: https://reviews.apache.org/r/32700/ - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32584/#review78171 ----------------------------------------------------------- On March 31, 2015, 4:28 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32584/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 4:28 p.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-2557 > https://issues.apache.org/jira/browse/MESOS-2557 > > > Repository: mesos > > > Description > ------- > > Framework constructor takes FrameworkInfo, which already has a valid > FrameworkID. > > > Diffs > ----- > > src/master/master.hpp 3c957abcb54a0c23b8549c1d21d2d9277791938d > src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 > src/slave/slave.hpp 19e6b44bc344c0ca509674803f401cbb4e1f47ae > src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16 > > Diff: https://reviews.apache.org/r/32584/diff/ > > > Testing > ------- > > make check > > TODO: Test for upgrade path. > > > Thanks, > > Kapil Arya > > --===============5467500025047892360==--