Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D586217E03 for ; Tue, 31 Mar 2015 03:55:28 +0000 (UTC) Received: (qmail 30856 invoked by uid 500); 31 Mar 2015 03:55:16 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 30788 invoked by uid 500); 31 Mar 2015 03:55:16 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 30773 invoked by uid 99); 31 Mar 2015 03:55:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Mar 2015 03:55:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3DC881D6F81; Tue, 31 Mar 2015 03:55:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6519399645288591501==" MIME-Version: 1.0 Subject: Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class From: "Paul Brett" To: "Cong Wang" , "Ian Downes" , "Chi Zhang" Cc: "Mesos ReviewBot" , "mesos" , "Paul Brett" Date: Tue, 31 Mar 2015 03:55:14 -0000 Message-ID: <20150331035514.16792.99658@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Paul Brett" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/32655/ X-Sender: "Paul Brett" References: <20150331035250.16791.47677@reviews.apache.org> In-Reply-To: <20150331035250.16791.47677@reviews.apache.org> Reply-To: "Paul Brett" X-ReviewRequest-Repository: mesos --===============6519399645288591501== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32655/ ----------------------------------------------------------- (Updated March 31, 2015, 3:55 a.m.) Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. Changes ------- Remove dependency on having applied waitForFileCreation first Bugs: mesos-2332 https://issues.apache.org/jira/browse/mesos-2332 Repository: mesos Description ------- Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class Diffs (updated) ----- src/tests/port_mapping_tests.cpp f4124c3 Diff: https://reviews.apache.org/r/32655/diff/ Testing ------- Thanks, Paul Brett --===============6519399645288591501==--