Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D91F17599 for ; Fri, 27 Mar 2015 16:28:00 +0000 (UTC) Received: (qmail 46894 invoked by uid 500); 27 Mar 2015 16:27:25 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 46824 invoked by uid 500); 27 Mar 2015 16:27:25 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 46801 invoked by uid 99); 27 Mar 2015 16:27:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Mar 2015 16:27:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 761BA1D55C0; Fri, 27 Mar 2015 16:27:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0357273927637267657==" MIME-Version: 1.0 Subject: Re: Review Request 31265: Provided a factory for allocator in tests. From: "Alexander Rukletsov" To: "Niklas Nielsen" , "Michael Park" , "Kapil Arya" Cc: "Alexander Rukletsov" , "mesos" Date: Fri, 27 Mar 2015 16:27:24 -0000 Message-ID: <20150327162724.15432.59995@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rukletsov" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31265/ X-Sender: "Alexander Rukletsov" References: <20150323141115.32590.12864@reviews.apache.org> In-Reply-To: <20150323141115.32590.12864@reviews.apache.org> Reply-To: "Alexander Rukletsov" X-ReviewRequest-Repository: mesos --===============0357273927637267657== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/ ----------------------------------------------------------- (Updated March 27, 2015, 4:27 p.m.) Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. Changes ------- Addressed MParks's comments. Bugs: MESOS-2160 https://issues.apache.org/jira/browse/MESOS-2160 Repository: mesos Description ------- The factory creates allocator instances in a way identical to how instances from modules are created. It allows us to use same typed tests for built-in and modularized allocators. Diffs (updated) ----- src/master/allocator/mesos/allocator.hpp fb898f1175b61b442204e6e38c69ccc2838a646f src/tests/master_allocator_tests.cpp 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302 Diff: https://reviews.apache.org/r/31265/diff/ Testing ------- make check (Mac OS 10.9.5, Ubuntu 14.04) Thanks, Alexander Rukletsov --===============0357273927637267657==--