Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B9261788A for ; Fri, 27 Mar 2015 00:02:00 +0000 (UTC) Received: (qmail 39964 invoked by uid 500); 27 Mar 2015 00:02:00 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 39899 invoked by uid 500); 27 Mar 2015 00:02:00 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 39886 invoked by uid 99); 27 Mar 2015 00:02:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Mar 2015 00:02:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 301AA1D54BC; Fri, 27 Mar 2015 00:01:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1807607340250101557==" MIME-Version: 1.0 Subject: Re: Review Request 32550: Add major, minor, and patch accessors to stout's Version. From: "Joris Van Remoortere" To: "Joris Van Remoortere" , "mesos" Date: Fri, 27 Mar 2015 00:01:59 -0000 Message-ID: <20150327000159.1504.60055@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joris Van Remoortere" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/32550/ X-Sender: "Joris Van Remoortere" References: <20150326212055.1504.87314@reviews.apache.org> In-Reply-To: <20150326212055.1504.87314@reviews.apache.org> Reply-To: "Joris Van Remoortere" X-ReviewRequest-Repository: mesos --===============1807607340250101557== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32550/ ----------------------------------------------------------- (Updated March 27, 2015, 12:01 a.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Bugs: MESOS-1795 and MESOS-2161 https://issues.apache.org/jira/browse/MESOS-1795 https://issues.apache.org/jira/browse/MESOS-2161 Repository: mesos Description ------- We called them majorVersion, minorVersion, and patchVersion to avoid conflicting with major() and minor() (http://man.he.net/man3/gnu_dev_major) Diffs ----- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 090fcf09dd96538a8748cf4443d150911e2c0d27 Diff: https://reviews.apache.org/r/32550/diff/ Testing ------- Thanks, Joris Van Remoortere --===============1807607340250101557==--