Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============5361191568040296408=="
MIME-Version: 1.0
Subject: Re: Review Request 32139: Add 'Resource::ReservationInfo' protobuf
 message.
From: "Michael Park" <mcypark@gmail.com>
To: "Alexander Rukletsov" <rukletsov@gmail.com>,
 "Jie Yu" <yujie.jay@gmail.com>,
 "Ben Mahler" <benjamin.mahler@gmail.com>
Cc: "Michael Park" <mcypark@gmail.com>, "Timothy Chen" <tnachen@apache.org>,
 "mesos" <dev@mesos.apache.org>
Date: Wed, 25 Mar 2015 18:48:45 -0000
Message-ID: <20150325184845.1504.37447@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Michael Park" <noreply@reviews.apache.org>
References: <20150324072506.1505.68947@reviews.apache.org>
In-Reply-To: <20150324072506.1505.68947@reviews.apache.org>
Reply-To: "Michael Park" <mcypark@gmail.com>

--===============5361191568040296408==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On March 24, 2015, 7:25 a.m., Timothy Chen wrote:
> > include/mesos/mesos.proto, line 397
> > <https://reviews.apache.org/r/32139/diff/2/?file=899198#file899198line397>
> >
> >     Not sure this is the right place to comment on the valid specifications of both role and reservation. There is a user guide added right? We should refer to that instead.
> 
> Michael Park wrote:
>     Hm, the user guide doesn't exist in the repo. Maybe we just say something like: "Refer to the reservations user guide for the valid states and transitions of (role, reservation) pair." and add in the links together with the user guide later?

It seems weird to refer to a user guide that doesn't exist yet. I'll add the comment here with the link to the user guide when the user guide is ready to be added to the repo.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32139/#review77536
-----------------------------------------------------------


On March 25, 2015, 6:47 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32139/
> -----------------------------------------------------------
> 
> (Updated March 25, 2015, 6:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
> 
> 
> Bugs: MESOS-2475
>     https://issues.apache.org/jira/browse/MESOS-2475
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The beginning of `Resource::ReservationInfo`. This patch only introduces the `framework_id` field. We don't need the required `principal` field yet and will be introduced together with the "unreserve" ACLs. An optional `id` may be introduced in the future as well.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8 
> 
> Diff: https://reviews.apache.org/r/32139/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>


--===============5361191568040296408==--