Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AC9E1178B3 for ; Tue, 24 Mar 2015 20:34:09 +0000 (UTC) Received: (qmail 14738 invoked by uid 500); 24 Mar 2015 20:34:09 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 14670 invoked by uid 500); 24 Mar 2015 20:34:09 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 14656 invoked by uid 99); 24 Mar 2015 20:34:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Mar 2015 20:34:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 70D6D1D326A; Tue, 24 Mar 2015 20:34:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5174643020085167767==" MIME-Version: 1.0 Subject: Re: Review Request 32337: Moved http::initialize from header to .cpp file. From: "Vinod Kone" To: "Jie Yu" Cc: "Vinod Kone" , "Ben Mahler" , "mesos" Date: Tue, 24 Mar 2015 20:34:08 -0000 Message-ID: <20150324203408.1505.34492@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/32337/ X-Sender: "Vinod Kone" References: <20150320235110.1490.29295@reviews.apache.org> In-Reply-To: <20150320235110.1490.29295@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos --===============5174643020085167767== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32337/#review77635 ----------------------------------------------------------- Ship it! Ship It! - Vinod Kone On March 20, 2015, 11:51 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32337/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 11:51 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Many of the other http definitions are already moved to the .cpp file, this continues that trend. > > Moving them out makes the API a lot more readable from the scanning the header. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp 2b366986b1f617e95bda94e07f2a0e532f5626f6 > 3rdparty/libprocess/src/http.cpp 276cecd17364989093e6eed8e97ff3a02fb0d0ef > > Diff: https://reviews.apache.org/r/32337/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > > --===============5174643020085167767==--