Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4BAB01057A for ; Tue, 17 Mar 2015 21:54:15 +0000 (UTC) Received: (qmail 18736 invoked by uid 500); 17 Mar 2015 21:54:15 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 18663 invoked by uid 500); 17 Mar 2015 21:54:15 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 18643 invoked by uid 99); 17 Mar 2015 21:54:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2015 21:54:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CE20E1D42DF; Tue, 17 Mar 2015 21:54:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4501520065718866523==" MIME-Version: 1.0 Subject: Re: Review Request 32130: Ensured TaskStatus::source field is set for executor status updates. From: "Alexander Rukletsov" To: "Niklas Nielsen" , "Vinod Kone" Cc: "Adam B" , "mesos" , "Mesos ReviewBot" , "Alexander Rukletsov" Date: Tue, 17 Mar 2015 21:54:13 -0000 Message-ID: <20150317215413.391.82721@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rukletsov" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/32130/ X-Sender: "Alexander Rukletsov" References: <20150317215017.392.84109@reviews.apache.org> In-Reply-To: <20150317215017.392.84109@reviews.apache.org> Reply-To: "Alexander Rukletsov" X-ReviewRequest-Repository: mesos --===============4501520065718866523== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32130/ ----------------------------------------------------------- (Updated March 17, 2015, 9:54 p.m.) Review request for mesos, Niklas Nielsen and Vinod Kone. Changes ------- Tested on gcc4.4 Bugs: MESOS-2499 https://issues.apache.org/jira/browse/MESOS-2499 Repository: mesos Description ------- A status update originating from executor should have the TaskStatus::source field set to TaskStatus::SOURCE_EXECUTOR. Set this field in the slave to be future proof (a future where there will be no executor driver). Previous code has a bug and updated a copy of the update that was not forwarded. Add some checks for source and reason for status updates in existing tests. NOTE: Passing argument by value instead of `const&` is not fully consistent with our codebase, but not entirely alien; it also documents our intention. This approach should be fine, since `install()` deduces argument types from the return values of getter functions of protobuf messaged. Diffs ----- src/slave/slave.hpp 989832f8783d07d0702b30f0a68b8c383b57c621 src/slave/slave.cpp 0f99e4efb8fa2b96f120a3e49191158ca0364c06 src/tests/slave_tests.cpp a975305430097a8295b4b155e8448572c12bde22 Diff: https://reviews.apache.org/r/32130/diff/ Testing (updated) ------- make check (Mac OS 10.9.5, CentOS 7.0.1406, g++-4.4 @ Ubuntu 14.04) Thanks, Alexander Rukletsov --===============4501520065718866523==--