Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============2475275528197917052=="
MIME-Version: 1.0
Subject: Re: Review Request 32108: Added manual make for readability training
 source code
From: "Mesos ReviewBot" <dev@mesos.apache.org>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Ben Mahler" <benjamin.mahler@gmail.com>
Cc: "Mesos ReviewBot" <dev@mesos.apache.org>,
 "Bernd Mathiske" <bernd@mesosphere.io>, "mesos" <dev@mesos.apache.org>
Date: Mon, 16 Mar 2015 16:16:45 -0000
Message-ID: <20150316161645.392.23983@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
References: <20150316160944.391.15665@reviews.apache.org>
In-Reply-To: <20150316160944.391.15665@reviews.apache.org>
Reply-To: "Mesos ReviewBot" <dev@mesos.apache.org>

--===============2475275528197917052==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32108/#review76567
-----------------------------------------------------------


Bad patch!

Reviews applied: [32108]

Failed command: make -j3 distcheck

Error:
 make  dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d "mesos-0.23.0"; then find "mesos-0.23.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "mesos-0.23.0" || { sleep 5 && rm -rf "mesos-0.23.0"; }; else :; fi
test -d "mesos-0.23.0" || mkdir "mesos-0.23.0"
 (cd 3rdparty && make  top_distdir=../mesos-0.23.0 distdir=../mesos-0.23.0/3rdparty \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
 (cd libprocess && make  top_distdir=../../mesos-0.23.0 distdir=../../mesos-0.23.0/3rdparty/libprocess \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d "../../mesos-0.23.0/3rdparty/libprocess" || mkdir "../../mesos-0.23.0/3rdparty/libprocess"
 (cd 3rdparty && make  top_distdir=../../../mesos-0.23.0 distdir=../../../mesos-0.23.0/3rdparty/libprocess/3rdparty \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
 (cd stout && make  top_distdir=../../../../mesos-0.23.0 distdir=../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[5]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d "../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout" || mkdir "../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout"
 (cd include && make  top_distdir=../../../../../mesos-0.23.0 distdir=../../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout/include \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[6]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
make[6]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/include'
test -n ":" \
	|| find "../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout" -type d ! -perm -755 \
		-exec chmod u+rwx,go+rx {} \; -o \
	  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -444 -exec /bin/bash /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh -c -m a+r {} {} \; \
	|| chmod -R a+r "../../../../mesos-0.23.0/3rdparty/libprocess/3rdparty/stout"
make[5]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
 (cd include && make  top_distdir=../../../mesos-0.23.0 distdir=../../../mesos-0.23.0/3rdparty/libprocess/include \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/include'
test -n ":" \
	|| find "../../mesos-0.23.0/3rdparty/libprocess" -type d ! -perm -755 \
		-exec chmod u+rwx,go+rx {} \; -o \
	  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -444 -exec /bin/bash /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh -c -m a+r {} {} \; \
	|| chmod -R a+r "../../mesos-0.23.0/3rdparty/libprocess"
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
 (cd src && make  top_distdir=../mesos-0.23.0 distdir=../mesos-0.23.0/src \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
test ".." = ".." ||			\
		(/bin/mkdir -p python/src/mesos && cp -pf ./python/src/mesos/__init__.py python/src/mesos/__init__.py)
test ".." = ".." ||			\
		(/bin/mkdir -p python/interface/src/mesos && cp -pf ./python/interface/src/mesos/__init__.py python/interface/src/mesos/__init__.py)
test ".." = ".." ||			\
		(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf ./python/interface/src/mesos/interface/__init__.py python/interface/src/mesos/interface/__init__.py)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos && cp -pf ./python/native/src/mesos/__init__.py python/native/src/mesos/__init__.py)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/__init__.py python/native/src/mesos/native/__init__.py)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/mesos_executor_driver_impl.cpp python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/mesos_executor_driver_impl.hpp python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/module.cpp python/native/src/mesos/native/module.cpp)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/module.hpp python/native/src/mesos/native/module.hpp)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/proxy_executor.cpp python/native/src/mesos/native/proxy_executor.cpp)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/proxy_executor.hpp python/native/src/mesos/native/proxy_executor.hpp)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/proxy_scheduler.cpp python/native/src/mesos/native/proxy_scheduler.cpp)
test ".." = ".." ||			\
		(/bin/mkdir -p python/native/src/mesos/native && cp -pf ./python/native/src/mesos/native/proxy_scheduler.hpp python/native/src/mesos/native/proxy_scheduler.hpp)
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
 (cd ec2 && make  top_distdir=../mesos-0.23.0 distdir=../mesos-0.23.0/ec2 \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/ec2'
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/ec2'
test -n "" \
	|| find "mesos-0.23.0" -type d ! -perm -755 \
		-exec chmod u+rwx,go+rx {} \; -o \
	  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
	  ! -type d ! -perm -444 -exec /bin/bash /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/install-sh -c -m a+r {} {} \; \
	|| chmod -R a+r "mesos-0.23.0"
tardir=mesos-0.23.0 && ${TAR-tar} chof - "$tardir" | GZIP=--best gzip -c >mesos-0.23.0.tar.gz
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
if test -d "mesos-0.23.0"; then find "mesos-0.23.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "mesos-0.23.0" || { sleep 5 && rm -rf "mesos-0.23.0"; }; else :; fi
case 'mesos-0.23.0.tar.gz' in \
	*.tar.gz*) \
	  GZIP=--best gzip -dc mesos-0.23.0.tar.gz | ${TAR-tar} xf - ;;\
	*.tar.bz2*) \
	  bzip2 -dc mesos-0.23.0.tar.bz2 | ${TAR-tar} xf - ;;\
	*.tar.lz*) \
	  lzip -dc mesos-0.23.0.tar.lz | ${TAR-tar} xf - ;;\
	*.tar.xz*) \
	  xz -dc mesos-0.23.0.tar.xz | ${TAR-tar} xf - ;;\
	*.tar.Z*) \
	  uncompress -c mesos-0.23.0.tar.Z | ${TAR-tar} xf - ;;\
	*.shar.gz*) \
	  GZIP=--best gzip -dc mesos-0.23.0.shar.gz | unshar ;;\
	*.zip*) \
	  unzip mesos-0.23.0.zip ;;\
	esac
chmod -R a-w mesos-0.23.0
chmod u+w mesos-0.23.0
mkdir mesos-0.23.0/_build mesos-0.23.0/_inst
chmod a-w mesos-0.23.0
test -d mesos-0.23.0/_build || exit 0; \
	dc_install_base=`CDPATH="${ZSH_VERSION+.}:" && cd mesos-0.23.0/_inst && pwd | sed -e 's,^[^:\\/]:[\\/],/,'` \
	  && dc_destdir="${TMPDIR-/tmp}/am-dc-$$/" \
	  && am__cwd=`pwd` \
	  && CDPATH="${ZSH_VERSION+.}:" && cd mesos-0.23.0/_build \
	  && ../configure \
	    --disable-python-dependency-install \
	     \
	    --srcdir=.. --prefix="$dc_install_base" \
	  && make  \
	  && make  dvi \
	  && make  check \
	  && make  install \
	  && make  installcheck \
	  && make  uninstall \
	  && make  distuninstallcheck_dir="$dc_install_base" \
	        distuninstallcheck \
	  && chmod -R a-w "$dc_install_base" \
	  && ({ \
	       (cd ../.. && umask 077 && mkdir "$dc_destdir") \
	       && make  DESTDIR="$dc_destdir" install \
	       && make  DESTDIR="$dc_destdir" uninstall \
	       && make  DESTDIR="$dc_destdir" \
	            distuninstallcheck_dir="$dc_destdir" distuninstallcheck; \
	      } || { rm -rf "$dc_destdir"; exit 1; }) \
	  && rm -rf "$dc_destdir" \
	  && make  dist \
	  && rm -rf mesos-0.23.0.tar.gz \
	  && make  distcleancheck \
	  && cd "$am__cwd" \
	  || exit 1
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking for ar... ar
checking the archiver (ar) interface... ar
checking how to print strings... printf
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 3458764513820540925
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
configure: creating ./config.lt
config.lt: creating libtool
configure: Setting up build environment for x86_64 linux-gnu
checking whether we are using the GNU C++ compiler... (cached) yes
checking whether g++ accepts -g... (cached) yes
checking dependency style of g++... (cached) gcc3
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking if compiling with clang... no
configure: GCC version: 4.8
configure: Setting up CXXFLAGS for g++ version >= 4.8
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=c++11... yes
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... yes
checking whether -pthread is sufficient with -shared... yes
checking for backtrace in -lunwind... no
checking for gzread in -lz... yes
checking for curl_global_init in -lcurl... yes
checking apr_pools.h usability... yes
checking apr_pools.h presence... yes
checking for apr_pools.h... yes
checking for apr_initialize in -lapr-1... yes
checking svn_version.h usability... yes
checking svn_version.h presence... yes
checking for svn_version.h... yes
checking for svn_stringbuf_create_ensure in -lsvn_subr-1... yes
checking svn_delta.h usability... yes
checking svn_delta.h presence... yes
checking for svn_delta.h... yes
checking for svn_txdelta in -lsvn_delta-1... yes
checking for sasl_done in -lsasl2... yes
checking whether or not we can build with JNI... yes
checking for mvn... /home/jenkins/tools/maven/latest/bin/mvn
checking for a Python interpreter with version >= 2.6... python
checking for python... /usr/bin/python
checking for python version... 2.7
checking for python platform... linux2
checking for python script directory... ${prefix}/lib/python2.7/site-packages
checking for python extension module directory... ${exec_prefix}/lib/python2.7/site-packages
checking for python2.7... (cached) /usr/bin/python
checking for a version of Python >= '2.1.0'... yes
checking for a version of Python >= '2.6'... yes
checking for the distutils Python package... yes
checking for Python include path... -I/usr/include/python2.7
checking for Python library path... -L/usr/lib -lpython2.7
checking for Python site-packages path... /usr/lib/python2.7/dist-packages
checking python extra libraries... -lpthread -ldl  -lutil
checking python extra linking flags... -Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions
checking consistency of all components of python development environment... yes
checking whether we can build usable Python eggs... cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++ [enabled by default]
yes
checking for an old installation of the Mesos egg (before 0.20.0)... no
checking python2 module: boto... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating mesos.pc
config.status: creating ec2/Makefile
config.status: creating src/Makefile
config.status: creating 3rdparty/Makefile
config.status: error: cannot find input file: `readability/Makefile.in'
make: *** [distcheck] Error 1

- Mesos ReviewBot


On March 16, 2015, 4:09 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32108/
> -----------------------------------------------------------
> 
> (Updated March 16, 2015, 4:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Readability source code now has a Makefile that is generated by bootstrap and configure. "cd build/readability; make" compiles the sources in "readability/". No linking occurs. This is just to ensure that we have syntactially correct and type-checked example files.
> 
> Slightly rearranged the content of naming_*.cpp and broke out an extra file for whitespace issues.
> 
> Replaces:
> https://reviews.apache.org/r/31990/
> https://reviews.apache.org/r/31992/
> 
> 
> Diffs
> -----
> 
>   configure.ac 9b2d7f15f535aaaf85faf9b4f7af750f1dbdf472 
>   readability/Makefile.am PRE-CREATION 
>   readability/TODO PRE-CREATION 
>   readability/naming_comments.cpp PRE-CREATION 
>   readability/naming_review.cpp PRE-CREATION 
>   readability/whitespace_comments.cpp PRE-CREATION 
>   readability/whitespace_review.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32108/diff/
> 
> 
> Testing
> -------
> 
> cd build/readability; make
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


--===============2475275528197917052==--