Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7CFA517DB3 for ; Sat, 14 Mar 2015 00:11:04 +0000 (UTC) Received: (qmail 8062 invoked by uid 500); 14 Mar 2015 00:11:04 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 7990 invoked by uid 500); 14 Mar 2015 00:11:04 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 7965 invoked by uid 99); 14 Mar 2015 00:11:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Mar 2015 00:11:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 78D581D41D0; Sat, 14 Mar 2015 00:11:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8562998761582224008==" MIME-Version: 1.0 Subject: Re: Review Request 31838: Fixed authentication failure triggered slave crash. From: "Alexander Rukletsov" To: "Vinod Kone" , "Adam B" , "Alexander Rojas" , "Joerg Schad" Cc: "Alexander Rukletsov" , "mesos" , "Till Toenshoff" Date: Sat, 14 Mar 2015 00:11:03 -0000 Message-ID: <20150314001103.1508.29142@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rukletsov" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31838/ X-Sender: "Alexander Rukletsov" References: <20150309005443.17901.25018@reviews.apache.org> In-Reply-To: <20150309005443.17901.25018@reviews.apache.org> Reply-To: "Alexander Rukletsov" X-ReviewRequest-Repository: mesos-incubating --===============8562998761582224008== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31838/#review76464 ----------------------------------------------------------- Ship it! src/slave/slave.cpp Does it make sense to flatten this for readability? Like this: ``` } else if (info.has_id()) { ... } else { ... } ``` - Alexander Rukletsov On March 9, 2015, 12:54 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31838/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 12:54 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Vinod Kone. > > > Bugs: MESOS-2464 > https://issues.apache.org/jira/browse/MESOS-2464 > > > Repository: mesos-incubating > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/slave/slave.cpp 364d911 > > Diff: https://reviews.apache.org/r/31838/diff/ > > > Testing > ------- > > make check && functional testing with failed authentication > > > Thanks, > > Till Toenshoff > > --===============8562998761582224008==--