Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A87B7173AA for ; Wed, 11 Mar 2015 18:43:18 +0000 (UTC) Received: (qmail 47714 invoked by uid 500); 11 Mar 2015 18:43:12 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 47648 invoked by uid 500); 11 Mar 2015 18:43:12 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 47621 invoked by uid 99); 11 Mar 2015 18:43:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Mar 2015 18:43:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 396071D3AF3; Wed, 11 Mar 2015 18:43:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5545112986522017729==" MIME-Version: 1.0 Subject: Review Request 31951: Added test for long lived executors. From: "Niklas Nielsen" To: "switched to 'mcypark'" , "Ben Mahler" , "Kapil Arya" Cc: "Niklas Nielsen" , "mesos" Date: Wed, 11 Mar 2015 18:43:10 -0000 Message-ID: <20150311184310.14617.62409@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Niklas Nielsen" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31951/ X-Sender: "Niklas Nielsen" Reply-To: "Niklas Nielsen" X-ReviewRequest-Repository: mesos --===============5545112986522017729== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31951/ ----------------------------------------------------------- Review request for mesos, Ben Mahler, Kapil Arya, and switched to 'mcypark'. Bugs: MESOS-2463 https://issues.apache.org/jira/browse/MESOS-2463 Repository: mesos Description ------- Environment decorators broke long lived executors during master fail over (MESOS-2463). This test verifies the fix suggested in r31889. Diffs ----- src/tests/master_tests.cpp acf7050ce69a196ac74627d607b4664060fa1117 Diff: https://reviews.apache.org/r/31951/diff/ Testing ------- make check with and without r31889. (Breaks before with TASK_ERROR similar to MESOS-2463): ------------------------------------------------------------ Existing ExecutorInfo: executor_id { value: "default" } command { environment { } value: "exit 1" } framework_id { value: "20150311-114156-3758096394-50894-29122-0000" } ------------------------------------------------------------ Task's ExecutorInfo: executor_id { value: "default" } command { value: "exit 1" } framework_id { value: "20150311-114156-3758096394-50894-29122-0000" } ------------------------------------------------------------ Thanks, Niklas Nielsen --===============5545112986522017729==--