Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 878C51762A for ; Mon, 9 Mar 2015 13:04:56 +0000 (UTC) Received: (qmail 19341 invoked by uid 500); 9 Mar 2015 13:04:56 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 19271 invoked by uid 500); 9 Mar 2015 13:04:56 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 28234 invoked by uid 99); 9 Mar 2015 12:23:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Mar 2015 12:23:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 60A9B1CAC34; Mon, 9 Mar 2015 12:23:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4855559966849907259==" MIME-Version: 1.0 Subject: Re: Review Request 31538: Added validations performed in the MesosExecutorDriver to the Slave. From: "Mesos ReviewBot" To: "Isabel Jimenez" , "Vinod Kone" , "Till Toenshoff" Cc: "Mesos ReviewBot" , "mesos" , "Alexander Rojas" Date: Mon, 09 Mar 2015 12:23:14 -0000 Message-ID: <20150309122314.17901.4205@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31538/ X-Sender: "Mesos ReviewBot" References: <20150309110937.17900.79885@reviews.apache.org> In-Reply-To: <20150309110937.17900.79885@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============4855559966849907259== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31538/#review75690 ----------------------------------------------------------- Patch looks great! Reviews applied: [31538] All tests passed. - Mesos ReviewBot On March 9, 2015, 11:09 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31538/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 11:09 a.m.) > > > Review request for mesos, Isabel Jimenez, Till Toenshoff, and Vinod Kone. > > > Bugs: mesos-2291 > https://issues.apache.org/jira/browse/mesos-2291 > > > Repository: mesos > > > Description > ------- > > Copies validations made to the messages exchanged between the slave and the `MesosExecutorDriver` and performed in the executor driver to the slave. This is requiered since the new HTTP API will deprecate the executor driver. > > > Diffs > ----- > > src/exec/exec.cpp d678f0682d803b0b080c3a6c296067ac9ab5dbf8 > src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876 > > Diff: https://reviews.apache.org/r/31538/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > > --===============4855559966849907259==--