Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00ED417CB7 for ; Sat, 7 Mar 2015 07:26:56 +0000 (UTC) Received: (qmail 91402 invoked by uid 500); 7 Mar 2015 07:26:55 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 91325 invoked by uid 500); 7 Mar 2015 07:26:55 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 91307 invoked by uid 99); 7 Mar 2015 07:26:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Mar 2015 07:26:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2E8A91C01C9; Sat, 7 Mar 2015 07:26:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9185052689150844782==" MIME-Version: 1.0 Subject: Re: Review Request 31667: Piped hashmap from allocator through to sorter. From: "Michael Park" To: "Alexander Rukletsov" , "Ben Mahler" Cc: "Michael Park" , "mesos" Date: Sat, 07 Mar 2015 07:26:54 -0000 Message-ID: <20150307072654.12262.82912@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Michael Park" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31667/ X-Sender: "Michael Park" References: <20150306230948.12263.50313@reviews.apache.org> In-Reply-To: <20150306230948.12263.50313@reviews.apache.org> Reply-To: "Michael Park" X-ReviewRequest-Repository: mesos --===============9185052689150844782== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 6, 2015, 11:09 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.hpp, lines 313-317 > > > > > > See my comment to https://reviews.apache.org/r/31666/. See my comment in [r31666](https://reviews.apache.org/r/31666/). - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31667/#review75561 ----------------------------------------------------------- On March 3, 2015, 8:29 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31667/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 8:29 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-2373 > https://issues.apache.org/jira/browse/MESOS-2373 > > > Repository: mesos > > > Description > ------- > > `Sorter` changes: > > - Augmented `add`, `remove`, `allocated`, `unallocated`, `update` with `SlaveID`. > - `allocation` returns `hashmap`. > > `DRFSorter` changes: > > - `allocations` is updated from `hashmap` to `hashmap>`. > - `resources` is updated from `Resources` to `hashmap`. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp c0b1da75565d9dc7728c5566f01815234163fc47 > src/master/allocator/sorter/drf/sorter.hpp 4366710d6530b784aa5094813328d0e338239ba0 > src/master/allocator/sorter/drf/sorter.cpp 2f69f384b95ff20d3ee429a4570a8cffa74d8e8b > src/master/allocator/sorter/sorter.hpp e2efb27b11dbea42dd73f81e5db0d6d2b0a6034b > src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd > > Diff: https://reviews.apache.org/r/31667/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > > --===============9185052689150844782==--