Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0773B174A7 for ; Sat, 7 Mar 2015 00:21:55 +0000 (UTC) Received: (qmail 73017 invoked by uid 500); 7 Mar 2015 00:21:54 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 72952 invoked by uid 500); 7 Mar 2015 00:21:54 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 72928 invoked by uid 99); 7 Mar 2015 00:21:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Mar 2015 00:21:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3D9771D3990; Sat, 7 Mar 2015 00:21:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3959726769746342310==" MIME-Version: 1.0 Subject: Re: Review Request 31664: Added operator+= and operator+ for hashmap. From: "Michael Park" To: "Alexander Rukletsov" , "Ben Mahler" Cc: "Michael Park" , "mesos" Date: Sat, 07 Mar 2015 00:21:53 -0000 Message-ID: <20150307002153.5896.42912@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Michael Park" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31664/ X-Sender: "Michael Park" References: <20150306232811.5896.70231@reviews.apache.org> In-Reply-To: <20150306232811.5896.70231@reviews.apache.org> Reply-To: "Michael Park" X-ReviewRequest-Repository: mesos --===============3959726769746342310== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 6, 2015, 11:28 p.m., Ben Mahler wrote: > > src/common/resources.cpp, lines 992-997 > > > > > > This looks inconsistent with all of the other + operator implementations in this file, no? Reverted for consistency. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31664/#review75571 ----------------------------------------------------------- On March 7, 2015, 12:21 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31664/ > ----------------------------------------------------------- > > (Updated March 7, 2015, 12:21 a.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-2373 > https://issues.apache.org/jira/browse/MESOS-2373 > > > Repository: mesos > > > Description > ------- > > Convenience functions to help aggregate `hashmap`. Used in [r31665](https://reviews.apache.org/r/31665). > > > Diffs > ----- > > include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812 > src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059 > > Diff: https://reviews.apache.org/r/31664/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > > --===============3959726769746342310==--