Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C97C17F8C for ; Fri, 6 Mar 2015 18:23:50 +0000 (UTC) Received: (qmail 85840 invoked by uid 500); 6 Mar 2015 18:23:50 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 85770 invoked by uid 500); 6 Mar 2015 18:23:50 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 85735 invoked by uid 99); 6 Mar 2015 18:23:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Mar 2015 18:23:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D88931D3196; Fri, 6 Mar 2015 18:23:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8517358577418526597==" MIME-Version: 1.0 Subject: Re: Review Request 31471: stout: Create IP and IPNetwork AF_INET abstraction. From: "Jie Yu" To: "Joris Van Remoortere" , "Benjamin Hindman" , "Jie Yu" , "Niklas Nielsen" , "Dominic Hamon" Cc: "Evelina Dumitrescu" , "mesos" Date: Fri, 06 Mar 2015 18:23:48 -0000 Message-ID: <20150306182348.12262.76861@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jie Yu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/31471/ X-Sender: "Jie Yu" References: <20150305193907.12263.14568@reviews.apache.org> In-Reply-To: <20150305193907.12263.14568@reviews.apache.org> Reply-To: "Jie Yu" X-ReviewRequest-Repository: mesos --===============8517358577418526597== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31471/#review75500 ----------------------------------------------------------- 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp For the same reason, please rename it to `isAny()` and add a comment here explaining what `Any` means. 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp As we discussed offline, no need to pass in `seed`. `hash_combine` will internally call `hash_value`. 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp As we discussed offline, please change the name of this function to: ``` static IPNetwork LOOPBACK_V4(); ``` , because you already have IP and Network in the class name, no need to mentioned it again. Also, this is like a constant, so use all capital case. - Jie Yu On March 5, 2015, 7:39 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31471/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 7:39 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen. > > > Repository: mesos > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 0cd7cb526a3a2514b3b54552253dfa8919e948d0 > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 9635bbc6f7dae1d75a780069fcc60fb706221053 > 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp fb98317a68986cb1228c584a8cd83b07737895a8 > > Diff: https://reviews.apache.org/r/31471/diff/ > > > Testing > ------- > > > Thanks, > > Evelina Dumitrescu > > --===============8517358577418526597==--